Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2595323002: Make use of ContextClient in modules/speech/ (Closed)

Created:
3 years, 12 months ago by sof
Modified:
3 years, 12 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make use of ContextClient in modules/speech/ Switch to reusing ContextClient rather than have SpeechSynthesis{Utterance} explicitly hold ExecutionContext member references. R= BUG=610176 Committed: https://crrev.com/ff20faea1e1860691a84d7aadedb689dcdf71181 Cr-Commit-Position: refs/heads/master@{#440432}

Patch Set 1 #

Patch Set 2 : complete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -19 lines) Patch
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.h View 1 4 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp View 1 4 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.h View 4 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
sof
just in case you haven't updated these two uses somewhere else already.
3 years, 12 months ago (2016-12-22 12:20:02 UTC) #4
haraken
LGTM
3 years, 12 months ago (2016-12-22 12:21:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595323002/20001
3 years, 12 months ago (2016-12-22 15:57:52 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-22 16:03:08 UTC) #17
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 16:05:09 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ff20faea1e1860691a84d7aadedb689dcdf71181
Cr-Commit-Position: refs/heads/master@{#440432}

Powered by Google App Engine
This is Rietveld 408576698