Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2595313002: DISALLOW_COPY_AND_ASSIGN the TabStripModelObserver. (Closed)

Created:
4 years ago by themblsha
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DISALLOW_COPY_AND_ASSIGN the TabStripModelObserver. Disable the implicitly generated special functions that perform copies and moves according to the Google C++ Style Guide. BUG=None Review-Url: https://codereview.chromium.org/2595313002 Cr-Commit-Position: refs/heads/master@{#442871} Committed: https://chromium.googlesource.com/chromium/src/+/b49e54ff3324352a847998ead77f4d27415ef094

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/ui/tabs/tab_strip_model_observer.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model_observer.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
themblsha
4 years ago (2016-12-22 11:37:00 UTC) #2
sky
LGTM
3 years, 11 months ago (2017-01-03 21:59:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595313002/1
3 years, 11 months ago (2017-01-11 10:39:04 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-11 11:30:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b49e54ff3324352a847998ead77f...

Powered by Google App Engine
This is Rietveld 408576698