MIPS: Reland of `Fix bad RegisterConfiguration usage in InstructionSequence unit tests`

MIPS: Reland of `Fix bad RegisterConfiguration usage in InstructionSequence unit tests`

Reland 0cf56232209d4c9c669b8426680de18806f6c29a

The original patch got reverted because testing RegisterConfiguration was
overwritten by turbofan RegisterConfiguration. This caused some test cases not being
properly tested. The new patch uses correct RegisterConfiguration.

Original commit message:
Test InstructionSequenceTest has been initialized with a testing RegisterConfiguration
instance defined in instruction-sequence-unittest.h, whereas class ExplicitOperand which
is being tested used RegisterConfiguration from instruction.cc. In case these two
instances are different, the tests would fail. The issue is fixed by using the same
instance of RegisterConfiguration both for test code and code under test.

Additionally, the tests in register-allocator-unittest.cc use hardcoded values
for register and begin failing is the hardcoded register is not available for
allocation. Fix by forcing the use of allocatable registers only.

TEST=unittests.MoveOptimizerTest.RemovesRedundantExplicit,unittests.RegisterAllocatorTest.SpillPhi
BUG=

Review-Url: https://codereview.chromium.org/2595293002
Cr-Commit-Position: refs/heads/master@{#41938}
Committed: https://chromium.googlesource.com/v8/v8/+/c42bbec953a962d9900701e322559d1f9ec8029d

[ivica.bogosavljevic, 2016-12-22 09:21:52]

ivica.bogosavljevic@imgtec.com changed reviewers:
+ mstarzinger@chromium.org, mtrofin@chromium.org, titzer@chromium.org

[ivica.bogosavljevic, 2016-12-22 09:21:53]

PTAL

[Mircea Trofin, 2016-12-22 16:21:28]

lgtm

https://codereview.chromium.org/2595293002/diff/1/src/compiler/instruction.h
File src/compiler/instruction.h (right):

https://codereview.chromium.org/2595293002/diff/1/src/compiler/instruction.h#...
src/compiler/instruction.h:1573: void SetRegisterConfigurationForTesting(
shouldn't this be static?

https://codereview.chromium.org/2595293002/diff/1/src/compiler/instruction.h#...
src/compiler/instruction.h:1575: void ClearRegisterConfigurationForTesting();
Is ClearRegisterConfigurationForTesting called anywhere? If not, I'd just remove
it. We can always add it later.

[ivica.bogosavljevic, 2016-12-23 08:40:28]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 08:40:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 09:15:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 09:15:06]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2016-12-23 10:15:21]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-23 10:15:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 10:43:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-23 10:43:04]

Dry run: This issue passed the CQ dry run.

[ivica.bogosavljevic, 2016-12-23 10:49:21]

The CQ bit was checked by ivica.bogosavljevic@imgtec.com

[ivica.bogosavljevic, 2016-12-23 10:49:21]

The patchset sent to the CQ was uploaded after l-g-t-m from mtrofin@chromium.org
Link to the patchset: https://codereview.chromium.org/2595293002/#ps20001
(title: "Address code review remarks")

[commit-bot: I haz the power, 2016-12-23 10:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-23 10:51:09]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482490161015290,
"parent_rev": "b571c6d1cea5b0513dfa748a6330c4cb8f4ca89e", "commit_rev":
"c42bbec953a962d9900701e322559d1f9ec8029d"}

[commit-bot: I haz the power, 2016-12-23 10:51:14]

Description was changed from

==========
MIPS: Reland of `Fix bad RegisterConfiguration usage in InstructionSequence unit
tests`

Reland 0cf56232209d4c9c669b8426680de18806f6c29a

The original patch got reverted because testing RegisterConfiguration was
overwritten by turbofan RegisterConfiguration. This caused some test cases not
being
properly tested. The new patch uses correct RegisterConfiguration.

Original commit message:
Test InstructionSequenceTest has been initialized with a testing
RegisterConfiguration
instance defined in instruction-sequence-unittest.h, whereas class
ExplicitOperand which
is being tested used RegisterConfiguration from instruction.cc. In case these
two
instances are different, the tests would fail. The issue is fixed by using the
same
instance of RegisterConfiguration both for test code and code under test.

Additionally, the tests in register-allocator-unittest.cc use hardcoded values
for register and begin failing is the hardcoded register is not available for
allocation. Fix by forcing the use of allocatable registers only.

TEST=unittests.MoveOptimizerTest.RemovesRedundantExplicit,unittests.RegisterAllocatorTest.SpillPhi
BUG=
==========

to

==========
MIPS: Reland of `Fix bad RegisterConfiguration usage in InstructionSequence unit
tests`

Reland 0cf56232209d4c9c669b8426680de18806f6c29a

The original patch got reverted because testing RegisterConfiguration was
overwritten by turbofan RegisterConfiguration. This caused some test cases not
being
properly tested. The new patch uses correct RegisterConfiguration.

Original commit message:
Test InstructionSequenceTest has been initialized with a testing
RegisterConfiguration
instance defined in instruction-sequence-unittest.h, whereas class
ExplicitOperand which
is being tested used RegisterConfiguration from instruction.cc. In case these
two
instances are different, the tests would fail. The issue is fixed by using the
same
instance of RegisterConfiguration both for test code and code under test.

Additionally, the tests in register-allocator-unittest.cc use hardcoded values
for register and begin failing is the hardcoded register is not available for
allocation. Fix by forcing the use of allocatable registers only.

TEST=unittests.MoveOptimizerTest.RemovesRedundantExplicit,unittests.RegisterAllocatorTest.SpillPhi
BUG=

Review-Url: https://codereview.chromium.org/2595293002
Cr-Commit-Position: refs/heads/master@{#41938}
Committed:
https://chromium.googlesource.com/v8/v8/+/c42bbec953a962d9900701e322559d1f9ec...
==========

[commit-bot: I haz the power, 2016-12-23 10:51:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/c42bbec953a962d9900701e322559d1f9ec...