Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2595233003: Revert of Android: Delete rezip in favor of zipalign -p (Closed)

Created:
4 years ago by agrieve
Modified:
4 years ago
Reviewers:
michaelbai, jbudorick
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Delete rezip in favor of zipalign -p (patchset #1 id:1 of https://codereview.chromium.org/2594803002/ ) Reason for revert: Broke downstream monochrome Original issue's description: > Android: Delete rezip in favor of zipalign -p > > There's no need for a custom alignment tool now that zipalign supports > page-aligning libraries. > > BUG=676029 > > Committed: https://crrev.com/5e7b486a42ae172313d28a6ef9c5e4bba38cd74f > Cr-Commit-Position: refs/heads/master@{#440140} TBR=michaelbai@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=676029, 676589 Committed: https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c Cr-Commit-Position: refs/heads/master@{#440457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+594 lines, -48 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/tools/apk_merger.py View 4 chunks +6 lines, -4 lines 0 comments Download
M build/android/gyp/apkbuilder.py View 2 chunks +5 lines, -9 lines 0 comments Download
M build/android/gyp/finalize_apk.py View 5 chunks +91 lines, -28 lines 0 comments Download
A build/android/rezip/BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download
A build/android/rezip/RezipApk.java View 1 chunk +448 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 6 chunks +19 lines, -6 lines 0 comments Download
M build/config/android/rules.gni View 4 chunks +13 lines, -1 line 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agrieve
Created Revert of Android: Delete rezip in favor of zipalign -p
4 years ago (2016-12-22 17:39:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595233003/1
4 years ago (2016-12-22 17:46:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 18:47:21 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8f43f71ff691157cd0db2725f527dc197c89685c Cr-Commit-Position: refs/heads/master@{#440457}
4 years ago (2016-12-22 18:49:36 UTC) #9
agrieve
3 years, 11 months ago (2017-01-06 02:51:49 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2612773005/ by agrieve@chromium.org.

The reason for reverting is: Still need to fix....

Powered by Google App Engine
This is Rietveld 408576698