Issue 2595213002: Tweaking lists of method names to treat in a special way.

Issue 2595213002: Tweaking lists of method names to treat in a special way. (Closed)

Created:
4 years ago by Łukasz Anforowicz

Modified:
4 years ago

Reviewers:
dcheng

CC:
chromium-reviews, nasko

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Tweaking lists of method names to treat in a special way. BUG=598141 Committed: https://crrev.com/49c85e01a1cb4c9da1ce92d5792c87738eb26b70 Cr-Commit-Position: refs/heads/master@{#440284}

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 10 (5 generated)

Łukasz Anforowicz

Daniel, can you PTAL? This adds exceptions for things that Nasko found: - "hash" - ...

4 years ago (2016-12-22 00:27:55 UTC) #2

dcheng

LGTM Not ideal with hash: mind starting a platform-architecture-dev thread to see if there any ...

4 years ago (2016-12-22 00:31:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595213002/1

4 years ago (2016-12-22 00:35:24 UTC) #5

commit-bot: I haz the power

4 years ago (2016-12-22 00:46:57 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/49c85e01a1cb4c9da1ce92d5792c87738eb26b70
Cr-Commit-Position: refs/heads/master@{#440284}