Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
Save 288 bytes in a table while we're at it, and make local to file.
Fix spelling of "Numberic".

Review-Url: https://codereview.chromium.org/2595203002
Committed: https://pdfium.googlesource.com/pdfium/+/fff400a5df032c2203eef9f76a5dbb164672df3d

[Tom Sepez, 2016-12-22 00:05:33]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 00:05:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-22 00:06:35]

Description was changed from

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.


Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
==========

to

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
==========

[Tom Sepez, 2016-12-22 00:06:36]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-12-22 00:07:25]

Description was changed from

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
==========

to

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
Save 288 bytes in a table while we're at it.
==========

[Tom Sepez, 2016-12-22 00:13:38]

Description was changed from

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
Save 288 bytes in a table while we're at it.
==========

to

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
Save 288 bytes in a table while we're at it, and make local to file.
Fix spelling of "Numberic".
==========

[dsinclair, 2017-01-02 18:06:17]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2017-01-02 18:06:18]

https://codereview.chromium.org/2595203002/diff/20001/xfa/fxbarcode/qrcode/BC...
File xfa/fxbarcode/qrcode/BC_QRCoderEncoder.cpp (right):

https://codereview.chromium.org/2595203002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRCoderEncoder.cpp:91:
AppendLengthInfo(splitResult.second.GetLength(), qrCode->GetVersion(),
Is it worth making a tempString = splitResults.second; to make it clearer what
.second is?

[Tom Sepez, 2017-01-03 22:25:59]

https://codereview.chromium.org/2595203002/diff/20001/xfa/fxbarcode/qrcode/BC...
File xfa/fxbarcode/qrcode/BC_QRCoderEncoder.cpp (right):

https://codereview.chromium.org/2595203002/diff/20001/xfa/fxbarcode/qrcode/BC...
xfa/fxbarcode/qrcode/BC_QRCoderEncoder.cpp:91:
AppendLengthInfo(splitResult.second.GetLength(), qrCode->GetVersion(),
On 2017/01/02 18:06:17, dsinclair wrote:
> Is it worth making a tempString = splitResults.second; to make it clearer what
> .second is?

Prolly not, the type of splitResults is explicit on line 79.

[dsinclair, 2017-01-04 14:16:51]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-04 14:16:51]

lgtm

[commit-bot: I haz the power, 2017-01-04 14:16:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 14:34:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483539411462920,
"parent_rev": "4741b291f462c0c4a5de4abf1653c3b3c87b613a", "commit_rev":
"fff400a5df032c2203eef9f76a5dbb164672df3d"}

[commit-bot: I haz the power, 2017-01-04 14:34:23]

Description was changed from

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
Save 288 bytes in a table while we're at it, and make local to file.
Fix spelling of "Numberic".
==========

to

==========
Remove CFX_ArrayTemplate in BC_QRCoderEncoder.

Also, class Make_Pair is confusing given std::make_pair().
No need for vectors of pointers when there are reasonable copy ctors.
Save 288 bytes in a table while we're at it, and make local to file.
Fix spelling of "Numberic".

Review-Url: https://codereview.chromium.org/2595203002
Committed:
https://pdfium.googlesource.com/pdfium/+/fff400a5df032c2203eef9f76a5dbb164672...
==========

[commit-bot: I haz the power, 2017-01-04 14:34:24]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/fff400a5df032c2203eef9f76a5dbb164672...