Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 2595183002: Don't duplicate values in LevelDBWrapperImpl::CommitBatch. (Closed)

Created:
4 years ago by Marijn Kruisselbrink
Modified:
4 years ago
Reviewers:
michaeln, jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't duplicate values in LevelDBWrapperImpl::CommitBatch. Instead just store keys and lookup values when actually committing to the database. BUG=644376 Committed: https://crrev.com/2d68b588bdb1940e05b5e1fe7027974f1d574e71 Cr-Commit-Position: refs/heads/master@{#440463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M content/browser/leveldb_wrapper_impl.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/leveldb_wrapper_impl.cc View 6 chunks +15 lines, -22 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Marijn Kruisselbrink
4 years ago (2016-12-22 00:47:35 UTC) #6
jam
lgtm
4 years ago (2016-12-22 19:03:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595183002/1
4 years ago (2016-12-22 19:06:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 19:09:58 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 19:12:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d68b588bdb1940e05b5e1fe7027974f1d574e71
Cr-Commit-Position: refs/heads/master@{#440463}

Powered by Google App Engine
This is Rietveld 408576698