Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2595173004: Import csswg-test@75a3f186b64787c9b7cb292a22d1f6e9237ff1bc (Closed)

Created:
4 years ago by qyearsley
Modified:
3 years, 12 months ago
Reviewers:
kojii, Manuel Rego
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Import csswg-test@75a3f186b64787c9b7cb292a22d1f6e9237ff1bc Using update-w3c-deps in Chromium de864efb596ca3df1a6df84a67f110221fb7bcaf. Import after https://github.com/w3c/csswg-test/pull/1157, making sure that it works now that the CRLF endings were removed. BUG=676763 Committed: https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6 Cr-Commit-Position: refs/heads/master@{#440676}

Patch Set 1 #

Patch Set 2 : Update expectations and baselines #

Patch Set 3 : Add caret-color failures to TestExpectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -97 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-ui-3/caret-color-009.html View 2 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-ui-3/caret-color-013.html View 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/css-ui-3/caret-color-021.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/lint.whitelist View 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001a.html View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001a-expected.html View 3 chunks +7 lines, -18 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b.html View 2 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/csswg-test/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-baseline-empty-001b-expected.html View 3 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 24 (18 generated)
qyearsley
4 years ago (2016-12-22 23:11:59 UTC) #9
kojii
lgtm, thank you for doing this.
4 years ago (2016-12-23 01:52:43 UTC) #12
Manuel Rego
LGTM too, but please mark as failure the caret-color tests: * caret-color-009.html * caret-color-013.html Pointing ...
3 years, 12 months ago (2016-12-23 08:36:41 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595173004/40001
3 years, 12 months ago (2016-12-24 20:01:50 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
3 years, 12 months ago (2016-12-24 21:25:13 UTC) #22
commit-bot: I haz the power
3 years, 12 months ago (2016-12-24 21:27:52 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ff62a1d1b18d235feb6c3aeb750aeb4ced1ec9c6
Cr-Commit-Position: refs/heads/master@{#440676}

Powered by Google App Engine
This is Rietveld 408576698