Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2595163002: Add origin() method on View and use it to simplify some callers. (Closed)

Created:
4 years ago by Peter Kasting
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, awdf+watch_chromium.org, Peter Beverloo, tfarina, mlamouri+watch-notifications_chromium.org, kalyank, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add origin() method on View and use it to simplify some callers. I only looked for calls to "bounds().origin()". We could probably change a lot more spots by fixing places that call both x() and y(). BUG=none TEST=none Committed: https://crrev.com/edf5fb1403295bb60531db023307944364f4d725 Cr-Commit-Position: refs/heads/master@{#441413}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M ash/common/system/tray/fixed_sized_scroll_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/screen_capture_notification_ui_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/views/app_list_main_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/app_list/views/apps_grid_view_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/message_center/views/message_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/notification_view_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/scroll_view_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/styled_label_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/dialog_client_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Peter Kasting
Not blocking anything. Should be easy to review. https://codereview.chromium.org/2595163002/diff/1/chrome/browser/ui/views/tabs/tab_strip.cc File chrome/browser/ui/views/tabs/tab_strip.cc (right): https://codereview.chromium.org/2595163002/diff/1/chrome/browser/ui/views/tabs/tab_strip.cc#newcode2596 chrome/browser/ui/views/tabs/tab_strip.cc:2596: gfx::Size ...
4 years ago (2016-12-21 22:56:20 UTC) #4
sky
LGTM
3 years, 11 months ago (2017-01-03 22:05:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595163002/20001
3 years, 11 months ago (2017-01-04 17:35:37 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 11 months ago (2017-01-04 18:30:52 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 18:33:17 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/edf5fb1403295bb60531db023307944364f4d725
Cr-Commit-Position: refs/heads/master@{#441413}

Powered by Google App Engine
This is Rietveld 408576698