Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2595153002:
Convert audiobuffersource-grain test to testharness (Closed)
|
Created:
3 years, 12 months ago by Raymond Toy Modified:
3 years, 11 months ago Reviewers:
hongchan CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert audiobuffersource-grain test to testharness
Manually convert test to use testharness
BUG=676394
TEST=audiobuffersource-grain.html
Committed: https://crrev.com/593e520625209e04e23d096052ef8a8e99c992b3
Cr-Commit-Position: refs/heads/master@{#441475}
Patch Set 1 #Patch Set 2 : Rebase and remove unneeded expected result #
Total comments: 3
Messages
Total messages: 19 (10 generated)
Description was changed from ========== Convert AudioBufferSource tests to testharness Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-grain.html ========== to ========== Convert audiobuffersource-grain test to testharness Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-grain.html ==========
The CQ bit was checked by rtoy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rtoy@chromium.org changed reviewers: + hongchan@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html (right): https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html:53: // passed. Just a thought: perhaps we need should().beNonZero()?
https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html (right): https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html:53: // passed. On 2017/01/04 21:40:55, hongchan wrote: > Just a thought: perhaps we need should().beNonZero()? Only if we add should().beZero(). :-) Both would be useful in some cases. Probably could have used JS find() or something instead?
The CQ bit was checked by rtoy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483566258308350,
"parent_rev": "cc95b903a306e9e58b866e341df7ddecae3d2696", "commit_rev":
"962ed014d4ce2c79fa536b2af53871bbb03400a8"}
Message was sent while issue was closed.
Description was changed from ========== Convert audiobuffersource-grain test to testharness Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-grain.html ========== to ========== Convert audiobuffersource-grain test to testharness Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-grain.html Review-Url: https://codereview.chromium.org/2595153002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html (right): https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html:53: // passed. On 2017/01/04 21:44:00, Raymond Toy wrote: > On 2017/01/04 21:40:55, hongchan wrote: > > Just a thought: perhaps we need should().beNonZero()? > > Only if we add should().beZero(). :-) > > Both would be useful in some cases. Probably could have used JS find() or > something instead? should().beZero() can be achieved by should().beConstantOf(0). We don't have an assertion for the non-zero array.
Message was sent while issue was closed.
Description was changed from ========== Convert audiobuffersource-grain test to testharness Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-grain.html Review-Url: https://codereview.chromium.org/2595153002 ========== to ========== Convert audiobuffersource-grain test to testharness Manually convert test to use testharness BUG=676394 TEST=audiobuffersource-grain.html Committed: https://crrev.com/593e520625209e04e23d096052ef8a8e99c992b3 Cr-Commit-Position: refs/heads/master@{#441475} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/593e520625209e04e23d096052ef8a8e99c992b3 Cr-Commit-Position: refs/heads/master@{#441475}
Message was sent while issue was closed.
On 2017/01/04 at 21:53:36, hongchan wrote: > https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... > File third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html (right): > > https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... > third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html:53: // passed. > On 2017/01/04 21:44:00, Raymond Toy wrote: > > On 2017/01/04 21:40:55, hongchan wrote: > > > Just a thought: perhaps we need should().beNonZero()? > > > > Only if we add should().beZero(). :-) > > > > Both would be useful in some cases. Probably could have used JS find() or > > something instead? > > should().beZero() can be achieved by should().beConstantOf(0). We don't have an assertion for the non-zero array. Maybe should().notBeConstantValueOf(x)? But that's something for the audit bug; I'll file an issue on that so we can track it.
Message was sent while issue was closed.
On 2017/01/05 16:58:15, Raymond Toy wrote: > On 2017/01/04 at 21:53:36, hongchan wrote: > > > https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... > > File > third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html > (right): > > > > > https://codereview.chromium.org/2595153002/diff/20001/third_party/WebKit/Layo... > > > third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-grain.html:53: > // passed. > > On 2017/01/04 21:44:00, Raymond Toy wrote: > > > On 2017/01/04 21:40:55, hongchan wrote: > > > > Just a thought: perhaps we need should().beNonZero()? > > > > > > Only if we add should().beZero(). :-) > > > > > > Both would be useful in some cases. Probably could have used JS find() or > > > something instead? > > > > should().beZero() can be achieved by should().beConstantOf(0). We don't have > an assertion for the non-zero array. > > Maybe should().notBeConstantValueOf(x)? But that's something for the audit bug; > I'll file an issue on that > so we can track it. SGTM. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
