use skia cgimage->bitmap routine

use skia cgimage->bitmap routine

In particular, this removes a dependency on PlatformCanvas ...

BUG=675977
Committed: https://crrev.com/ccc2155e4e16cf6b71707d97517a14625fc8c65f
Cr-Commit-Position: refs/heads/master@{#440667}

[reed1, 2016-12-21 19:42:01]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 19:42:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-12-21 19:42:59]

reed@google.com changed reviewers:
+ dcheng@chromium.org, fmalita@chromium.org

[reed1, 2016-12-21 19:43:39]

Description was changed from

==========
use skia cgimage->bitmap routine

BUG=675977
==========

to

==========
use skia cgimage->bitmap routine

In particular, this removes a dependency on PlatformCanvas ...

BUG=675977
==========

[reed1, 2016-12-21 20:07:26]

reed@google.com changed reviewers:
+ rohitrao@chromium.org

[reed1, 2016-12-21 20:07:26]

not sure why the old code differed from the ios version ...

[commit-bot: I haz the power, 2016-12-21 20:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 20:46:24]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-12-21 20:54:51]

https://codereview.chromium.org/2595113002/diff/1/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/2595113002/diff/1/skia/ext/skia_utils_mac.mm#...
skia/ext/skia_utils_mac.mm:189: (void)SkCreateBitmapFromCGImage(&bm, image);
I don't think I'm an owner for this code, but in Chrome:
- I think we usually don't explicitly ignore a return value unless it's marked
WARN_UNUSED_RESULT
- If we do want to explicit ignore it, we use base::ignore_result (not to be
confused with base::IgnoreResult... ugh, naming) to make it obvious.

[reed1, 2016-12-21 21:00:26]

https://codereview.chromium.org/2595113002/diff/1/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/2595113002/diff/1/skia/ext/skia_utils_mac.mm#...
skia/ext/skia_utils_mac.mm:189: (void)SkCreateBitmapFromCGImage(&bm, image);
On 2016/12/21 20:54:51, dcheng wrote:
> I don't think I'm an owner for this code, but in Chrome:
> - I think we usually don't explicitly ignore a return value unless it's marked
> WARN_UNUSED_RESULT
> - If we do want to explicit ignore it, we use base::ignore_result (not to be
> confused with base::IgnoreResult... ugh, naming) to make it obvious.

Done.

[reed1, 2016-12-21 21:01:29]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 21:02:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 21:33:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 21:33:43]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-12-21 22:37:22]

LGTM

https://codereview.chromium.org/2595113002/diff/20001/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/2595113002/diff/20001/skia/ext/skia_utils_mac...
skia/ext/skia_utils_mac.mm:187: SkBitmap bm;
Nit: bitmap

https://codereview.chromium.org/2595113002/diff/20001/skia/ext/skia_utils_mac...
skia/ext/skia_utils_mac.mm:190: return SkBitmap();
This is technically unnecessary, since SkCreateBitmapFromCGImage() states that
it leaves the original SkBitmap untouched. TBH, I'm uncertain what the value of
the return value here is; I could only find one caller, and they don't even
check the return value.

[reed1, 2016-12-22 13:42:53]

https://codereview.chromium.org/2595113002/diff/20001/skia/ext/skia_utils_mac.mm
File skia/ext/skia_utils_mac.mm (right):

https://codereview.chromium.org/2595113002/diff/20001/skia/ext/skia_utils_mac...
skia/ext/skia_utils_mac.mm:187: SkBitmap bm;
On 2016/12/21 22:37:22, dcheng wrote:
> Nit: bitmap

Done.

https://codereview.chromium.org/2595113002/diff/20001/skia/ext/skia_utils_mac...
skia/ext/skia_utils_mac.mm:190: return SkBitmap();
On 2016/12/21 22:37:22, dcheng wrote:
> This is technically unnecessary, since SkCreateBitmapFromCGImage() states that
> it leaves the original SkBitmap untouched. TBH, I'm uncertain what the value
of
> the return value here is; I could only find one caller, and they don't even
> check the return value.

It is a convenience if the caller wants to know if it failed, without having to
also check the out-parameter afterwards.

[reed1, 2016-12-22 13:43:19]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 13:43:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 14:14:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 14:14:56]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-12-23 14:00:07]

lgtm

[reed1, 2016-12-24 11:33:46]

The CQ bit was checked by reed@google.com

[reed1, 2016-12-24 11:33:47]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2595113002/#ps40001
(title: "bm -> bitmap")

[commit-bot: I haz the power, 2016-12-24 11:33:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-24 11:35:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-24 11:35:21]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[reed1, 2016-12-24 13:08:22]

The CQ bit was checked by reed@google.com

[reed1, 2016-12-24 13:08:22]

The patchset sent to the CQ was uploaded after l-g-t-m from
fmalita@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2595113002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-24 13:08:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-24 13:40:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482584902122710,
"parent_rev": "bdc118534e6cd109e2b89a7cd031508b9b98ad86", "commit_rev":
"b61546c36448c856a99347e67e5d61cfefa57292"}

[commit-bot: I haz the power, 2016-12-24 13:41:21]

Description was changed from

==========
use skia cgimage->bitmap routine

In particular, this removes a dependency on PlatformCanvas ...

BUG=675977
==========

to

==========
use skia cgimage->bitmap routine

In particular, this removes a dependency on PlatformCanvas ...

BUG=675977

Review-Url: https://codereview.chromium.org/2595113002
==========

[commit-bot: I haz the power, 2016-12-24 13:41:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-24 13:43:24]

Description was changed from

==========
use skia cgimage->bitmap routine

In particular, this removes a dependency on PlatformCanvas ...

BUG=675977

Review-Url: https://codereview.chromium.org/2595113002
==========

to

==========
use skia cgimage->bitmap routine

In particular, this removes a dependency on PlatformCanvas ...

BUG=675977

Committed: https://crrev.com/ccc2155e4e16cf6b71707d97517a14625fc8c65f
Cr-Commit-Position: refs/heads/master@{#440667}
==========

[commit-bot: I haz the power, 2016-12-24 13:43:25]

Patchset 4 (id:??) landed as
https://crrev.com/ccc2155e4e16cf6b71707d97517a14625fc8c65f
Cr-Commit-Position: refs/heads/master@{#440667}