Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2595093002: Remove some unnecessary using directives from tests. (Closed)

Created:
4 years ago by Bence
Modified:
4 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unnecessary using directives from tests. Committed: https://crrev.com/253dce0c0e7b7aaed7c468453d129dfce22d5948 Cr-Commit-Position: refs/heads/master@{#440275}

Patch Set 1 #

Patch Set 2 : Revert some shared files. #

Patch Set 3 : Remove unnecessary empty line. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -106 lines) Patch
M net/base/int128_unittest.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_http_stream_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_network_transaction_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/core/quic_server_session_base_test.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/tools/quic/quic_client_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_server_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_server_session_test.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M net/tools/quic/quic_simple_server_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Bence
Ryan: PTAL. Thank you.
4 years ago (2016-12-21 20:00:36 UTC) #7
Ryan Hamilton
lgtm
4 years ago (2016-12-21 20:18:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595093002/60001
4 years ago (2016-12-21 23:43:43 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years ago (2016-12-22 00:16:37 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-22 00:18:11 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/253dce0c0e7b7aaed7c468453d129dfce22d5948
Cr-Commit-Position: refs/heads/master@{#440275}

Powered by Google App Engine
This is Rietveld 408576698