Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2595033002: Update TaskTraits in easy_unlock_tpm_key_manager.cc. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
xiyuan, gab
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, tbarzic
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TaskTraits in easy_unlock_tpm_key_manager.cc. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org BUG=675660 Committed: https://crrev.com/c487be3e5e620a8032d69977fdbc00034328dc5a Cr-Commit-Position: refs/heads/master@{#440137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
fdoray
PTAL
4 years ago (2016-12-21 16:02:13 UTC) #4
gab
lgtm, thanks
4 years ago (2016-12-21 16:04:18 UTC) #5
xiyuan
lgtm
4 years ago (2016-12-21 17:13:02 UTC) #8
xiyuan
+tbarzic fyi
4 years ago (2016-12-21 17:13:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595033002/1
4 years ago (2016-12-21 17:23:27 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 17:28:40 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-21 17:31:17 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c487be3e5e620a8032d69977fdbc00034328dc5a
Cr-Commit-Position: refs/heads/master@{#440137}

Powered by Google App Engine
This is Rietveld 408576698