Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2595003002: Use std::deque for storing edges and children in heap snapshot. (Closed)

Created:
4 years ago by ulan
Modified:
3 years, 11 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use std::deque for storing edges and children in heap snapshot. This patch fixes OOM crash that happens for large heap where the total size of edges exceeds 2GB, which is the hard limit for v8::internal::List allocated using tcmalloc. BUG=chromium:675911 Review-Url: https://codereview.chromium.org/2595003002 Cr-Commit-Position: refs/heads/master@{#42004} Committed: https://chromium.googlesource.com/v8/v8/+/b00fc8be8a2ff527d8462bb9c0fff163bfce850f

Patch Set 1 #

Patch Set 2 : use decltype #

Patch Set 3 : fix ce #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -40 lines) Patch
M src/api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/profiler/heap-snapshot-generator.h View 5 chunks +9 lines, -8 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 7 chunks +15 lines, -18 lines 0 comments Download
M src/profiler/heap-snapshot-generator-inl.h View 1 2 1 chunk +9 lines, -5 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
ulan
PTAL. This is the CL that we worked on together today.
4 years ago (2016-12-21 14:51:29 UTC) #3
kozy
thanks! lgtm.
4 years ago (2016-12-21 15:05:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595003002/20001
4 years ago (2016-12-21 15:07:49 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/18301)
4 years ago (2016-12-21 15:15:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2595003002/40001
3 years, 11 months ago (2016-12-30 16:02:58 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2016-12-30 16:27:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/b00fc8be8a2ff527d8462bb9c0fff163bfc...

Powered by Google App Engine
This is Rietveld 408576698