Don't paint underline or selections over ellipsis in mixed-flow contexts

Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
Cr-Commit-Position: refs/heads/master@{#441486}

[rhogan, 2016-12-21 10:34:48]

Description was changed from

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

BUG=642454
==========

to

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

BUG=642454
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-12-21 12:06:57]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 12:07:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 13:50:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 13:50:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rhogan, 2016-12-21 14:29:32]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[rhogan, 2016-12-21 17:33:43]

robhogan@gmail.com changed reviewers:
+ szager@google.com

[rhogan, 2016-12-22 12:50:31]

Description was changed from

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

BUG=642454
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

BUG=642454, 642450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-12-22 12:51:02]

Description was changed from

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

BUG=642454, 642450
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-12-22 12:54:24]

Description was changed from

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[rhogan, 2016-12-22 13:07:19]

The CQ bit was checked by robhogan@gmail.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 13:07:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rhogan, 2016-12-22 13:25:43]

robhogan@gmail.com changed reviewers:
+ szager@chromium.org
- szager@google.com

[commit-bot: I haz the power, 2016-12-22 15:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 15:30:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rhogan, 2016-12-23 10:14:47]

Hi szager - would you have time to look at this in eae's absence?

[eae, 2017-01-02 18:35:50]

Very nice, LGTM!

[rhogan, 2017-01-02 19:31:42]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2017-01-02 19:31:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-02 21:00:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-02 21:00:53]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[rhogan, 2017-01-04 20:55:59]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2017-01-04 20:56:00]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/2594983002/#ps40001
(title: "bug 642454")

[commit-bot: I haz the power, 2017-01-04 20:56:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:21:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483563359572140,
"parent_rev": "33c2649a8483f2a10bb2729604303632332ce08c", "commit_rev":
"18a0b43d7ec95224d725576c5915ff68bbabd613"}

[commit-bot: I haz the power, 2017-01-04 22:21:35]

Description was changed from

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2594983002
==========

[commit-bot: I haz the power, 2017-01-04 22:21:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 22:24:24]

Description was changed from

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2594983002
==========

to

==========
Don't paint underline or selections over ellipsis in mixed-flow contexts

Also, ensure the selected text is painted correctly when an ellipsis is present
in a mixed-flow context (e.g. ltr text in an rtl container).

BUG=642454, 642450, 642460
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
Cr-Commit-Position: refs/heads/master@{#441486}
==========

[commit-bot: I haz the power, 2017-01-04 22:24:25]

Patchset 3 (id:??) landed as
https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
Cr-Commit-Position: refs/heads/master@{#441486}

[loyso (OOO), 2017-01-05 06:24:55]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2615843002/ by loyso@chromium.org.

The reason for reverting is: Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html.