Implementing promise-based commit for driving OffscreenCanvas animations

third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
index 3baaa558eddea907b35b9e796f19f502d25535da..ccf03411c90563686b5c482b797046072557bf11 100644
--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
@@ -37,7 +37,7 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final
     }
   };
 
-  void commit(ScriptState*, ExceptionState&);
+  ScriptPromise commit(ScriptState*, ExceptionState&);
 
   // CanvasRenderingContext implementation
   ~OffscreenCanvasRenderingContext2D() override;
@@ -101,13 +101,14 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final
   bool isPaintable() const final;
 
   RefPtr<StaticBitmapImage> transferToStaticBitmapImage();
+  void doCommit(RefPtr<StaticBitmapImage>);

[xlai (Olivia), 2016/12/21 19:54:25]

I am confused that you add a function signature in header without adding its
implementation in cpp. Do I miss anything?

[Justin Novosad, 2016/12/21 21:15:40]

Good catch. This is unused. It is a leftover from something I tried earlier.
Done.

 };
 
 DEFINE_TYPE_CASTS(OffscreenCanvasRenderingContext2D,
                   CanvasRenderingContext,
                   context,
-                  context->is2d() && context->getOffscreenCanvas(),
-                  context.is2d() && context.getOffscreenCanvas());
+                  context->is2d() && context->offscreenCanvas(),
+                  context.is2d() && context.offscreenCanvas());
 
 }  // namespace blink