Allow PowerMonitorDeviceSource to be used from sequenced tasks.

Allow PowerMonitorDeviceSource to be used from sequenced tasks.

Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631
Committed: https://crrev.com/d862577f490a63c436e1c7ac702eb2dbc3e3b990
Cr-Commit-Position: refs/heads/master@{#440148}

[fdoray, 2016-12-20 21:23:00]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 21:23:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 22:55:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:55:11]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-12-21 16:14:07]

fdoray@chromium.org changed reviewers:
+ dcheng@chromium.org

[fdoray, 2016-12-21 16:14:07]

PTAL

[dcheng, 2016-12-21 17:24:31]

LGTM, but let's make the CL description clearer about why this transformation is
required to make it sequence safe (I'm guessing it has to do with the fact the
ThreadTaskRunnerHandle::get() uses TLS, but I'm not really sure, and it's only
called in one place. To my eye, it wouldn't seem "that bad" =)

[fdoray, 2016-12-21 17:47:50]

Description was changed from

==========
Make PowerMonitorDeviceSource sequence-safe.

This CL allows PowerMonitorDeviceSource to be used from sequenced
tasks.

BUG=675631
==========

to

==========
Make PowerMonitorDeviceSource sequence-safe.

This CL allows PowerMonitorDeviceSource to be used from sequenced
tasks. Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631
==========

[fdoray, 2016-12-21 17:48:18]

Description was changed from

==========
Make PowerMonitorDeviceSource sequence-safe.

This CL allows PowerMonitorDeviceSource to be used from sequenced
tasks. Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631
==========

to

==========
Allow PowerMonitorDeviceSource to be used from sequenced tasks.

Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631
==========

[fdoray, 2016-12-21 17:48:27]

On 2016/12/21 17:24:31, dcheng wrote:
> LGTM, but let's make the CL description clearer about why this transformation
is
> required to make it sequence safe (I'm guessing it has to do with the fact the
> ThreadTaskRunnerHandle::get() uses TLS, but I'm not really sure, and it's only
> called in one place. To my eye, it wouldn't seem "that bad" =)

Done.

[fdoray, 2016-12-21 17:48:30]

The CQ bit was checked by fdoray@chromium.org

[commit-bot: I haz the power, 2016-12-21 17:48:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:58:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482342510356560, "parent_rev":
"bfb5c34e4c2191e9db5c77e948370322dfb64b86", "commit_rev":
"c53d6029ac5a748a6b70d40c09f47206b05f67cd"}

[commit-bot: I haz the power, 2016-12-21 17:58:52]

Description was changed from

==========
Allow PowerMonitorDeviceSource to be used from sequenced tasks.

Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631
==========

to

==========
Allow PowerMonitorDeviceSource to be used from sequenced tasks.

Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631

Review-Url: https://codereview.chromium.org/2594833002
==========

[commit-bot: I haz the power, 2016-12-21 17:58:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 18:02:50]

Description was changed from

==========
Allow PowerMonitorDeviceSource to be used from sequenced tasks.

Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631

Review-Url: https://codereview.chromium.org/2594833002
==========

to

==========
Allow PowerMonitorDeviceSource to be used from sequenced tasks.

Currently, it can't be used from sequenced tasks because
ThreadTaskRunnerHandle::IsSet() returns false when called from
a sequenced task.

BUG=675631

Committed: https://crrev.com/d862577f490a63c436e1c7ac702eb2dbc3e3b990
Cr-Commit-Position: refs/heads/master@{#440148}
==========

[commit-bot: I haz the power, 2016-12-21 18:02:51]

Patchset 1 (id:??) landed as
https://crrev.com/d862577f490a63c436e1c7ac702eb2dbc3e3b990
Cr-Commit-Position: refs/heads/master@{#440148}