Android: Delete rezip in favor of zipalign -p

Android: Delete rezip in favor of zipalign -p

There's no need for a custom alignment tool now that zipalign supports
page-aligning libraries.

BUG=676029
Committed: https://crrev.com/5e7b486a42ae172313d28a6ef9c5e4bba38cd74f
Cr-Commit-Position: refs/heads/master@{#440140}

[agrieve, 2016-12-20 19:59:39]

agrieve@chromium.org changed reviewers:
+ jbudorick@chromium.org, michaelbai@chromium.org

[michaelbai, 2016-12-20 20:26:02]

LGTM, we may also consider to combine uncompress_shared_libraries with
load_library_from_apk, though monochrome doesn't use crazy linker.

[jbudorick, 2016-12-20 21:29:51]

lgtm w/ ?s

https://codereview.chromium.org/2594803002/diff/1/build/android/gyp/apkbuilde...
File build/android/gyp/apkbuilder.py (right):

https://codereview.chromium.org/2594803002/diff/1/build/android/gyp/apkbuilde...
build/android/gyp/apkbuilder.py:169: and 'android_linker' not in basename):
This will mean that compress will be None (rather than False) for shared libs w/
'android_linker' in the name. Is that intentional?

https://codereview.chromium.org/2594803002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (left):

https://codereview.chromium.org/2594803002/diff/1/build/config/android/rules....
build/config/android/rules.gni:2013: # zipalign can't align gdb_server, don't
pack gdbserver temporarily.
I take it that it now can?

[agrieve, 2016-12-21 15:41:41]

https://codereview.chromium.org/2594803002/diff/1/build/android/gyp/apkbuilde...
File build/android/gyp/apkbuilder.py (right):

https://codereview.chromium.org/2594803002/diff/1/build/android/gyp/apkbuilde...
build/android/gyp/apkbuilder.py:169: and 'android_linker' not in basename):
On 2016/12/20 21:29:50, jbudorick wrote:
> This will mean that compress will be None (rather than False) for shared libs
w/
> 'android_linker' in the name. Is that intentional?

Yeah, this is the ugly part of the code, but it wasn't terribly pretty before
either (it was baked into rezip). But yes, it's intentional. We want to compress
libandroid_linker, and not compress libchrome.

https://codereview.chromium.org/2594803002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (left):

https://codereview.chromium.org/2594803002/diff/1/build/config/android/rules....
build/config/android/rules.gni:2013: # zipalign can't align gdb_server, don't
pack gdbserver temporarily.
On 2016/12/20 21:29:51, jbudorick wrote:
> I take it that it now can?

I didn't even try. afaik, there's no point in us embedding gdbserver in the
apks. adb_gdb always just goes and finds its own copy of it from the sdk
anyways, and I think that makes more sense.

[agrieve, 2016-12-21 15:41:52]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-12-21 15:42:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:36:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482334912098350, "parent_rev":
"c1ea21d63c646a98109cf8cdc0e3b315a6db0f6b", "commit_rev":
"40e85d20246b80807dd024a1f6dd1e33993a2411"}

[commit-bot: I haz the power, 2016-12-21 17:37:06]

Description was changed from

==========
Android: Delete rezip in favor of zipalign -p

There's no need for a custom alignment tool now that zipalign supports
page-aligning libraries.

BUG=676029
==========

to

==========
Android: Delete rezip in favor of zipalign -p

There's no need for a custom alignment tool now that zipalign supports
page-aligning libraries.

BUG=676029

Review-Url: https://codereview.chromium.org/2594803002
==========

[commit-bot: I haz the power, 2016-12-21 17:37:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 17:39:07]

Description was changed from

==========
Android: Delete rezip in favor of zipalign -p

There's no need for a custom alignment tool now that zipalign supports
page-aligning libraries.

BUG=676029

Review-Url: https://codereview.chromium.org/2594803002
==========

to

==========
Android: Delete rezip in favor of zipalign -p

There's no need for a custom alignment tool now that zipalign supports
page-aligning libraries.

BUG=676029

Committed: https://crrev.com/5e7b486a42ae172313d28a6ef9c5e4bba38cd74f
Cr-Commit-Position: refs/heads/master@{#440140}
==========

[commit-bot: I haz the power, 2016-12-21 17:39:08]

Patchset 1 (id:??) landed as
https://crrev.com/5e7b486a42ae172313d28a6ef9c5e4bba38cd74f
Cr-Commit-Position: refs/heads/master@{#440140}

[agrieve, 2016-12-22 17:39:41]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2595233003/ by agrieve@chromium.org.

The reason for reverting is: Broke downstream monochrome.