Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2594793005: Disallow passing a SharedArrayBuffer in the transfer list. (Closed)

Created:
4 years ago by binji
Modified:
3 years, 11 months ago
Reviewers:
jbroman, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disallow passing a SharedArrayBuffer in the transfer list. This behavior changed recently. SharedArrayBuffers should not be put in the transfer list, because they are not detached, and that is the meaning of being in the transfer list. This is the V8 side of the change, the Blink side will come next. Reland of https://codereview.chromium.org/2570433005, it was reverted because of a Blink-side test failure which has been temporarily disabled; see https://codereview.chromium.org/2590003002. BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=676063 Review-Url: https://codereview.chromium.org/2594793005 Cr-Commit-Position: refs/heads/master@{#42054} Committed: https://chromium.googlesource.com/v8/v8/+/534ddf645be293800ab0bd7107b307f668ac8d5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -36 lines) Patch
M include/v8.h View 3 chunks +20 lines, -4 lines 0 comments Download
M src/api.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/messages.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/value-serializer.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/value-serializer.cc View 5 chunks +25 lines, -15 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 7 chunks +50 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
binji
FYI: This is a reland, no new changes.
4 years ago (2016-12-21 21:53:51 UTC) #2
Jakob Kummerow
rubberstamp LGTM
4 years ago (2016-12-22 11:03:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594793005/1
3 years, 11 months ago (2017-01-03 21:55:40 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 22:52:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/534ddf645be293800ab0bd7107b307f668a...

Powered by Google App Engine
This is Rietveld 408576698