Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2594763002: MD WebUI: fix vulcanize.py for Windows (Closed)

Created:
4 years ago by Dan Beam
Modified:
4 years ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD WebUI: fix vulcanize.py for Windows R=dpapad@chromium.org BUG=673825 NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/29c4ba7e0a2d3003db7c7c77c702ed377ab8bceb Cr-Commit-Position: refs/heads/master@{#439864}

Patch Set 1 : asdf #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/vulcanize.py View 3 chunks +8 lines, -8 lines 2 comments Download

Messages

Total messages: 13 (7 generated)
Dan Beam
4 years ago (2016-12-20 18:46:29 UTC) #3
dpapad
lgtm https://codereview.chromium.org/2594763002/diff/20001/chrome/browser/resources/vulcanize.py File chrome/browser/resources/vulcanize.py (right): https://codereview.chromium.org/2594763002/diff/20001/chrome/browser/resources/vulcanize.py#newcode42 chrome/browser/resources/vulcanize.py:42: '--redirect', '"chrome://resources/cr_elements/|%s"' % _CR_ELEMENTS_PATH, Perhaps add a comment ...
4 years ago (2016-12-20 18:54:08 UTC) #4
Dan Beam
https://codereview.chromium.org/2594763002/diff/20001/chrome/browser/resources/vulcanize.py File chrome/browser/resources/vulcanize.py (right): https://codereview.chromium.org/2594763002/diff/20001/chrome/browser/resources/vulcanize.py#newcode42 chrome/browser/resources/vulcanize.py:42: '--redirect', '"chrome://resources/cr_elements/|%s"' % _CR_ELEMENTS_PATH, On 2016/12/20 18:54:08, dpapad wrote: ...
4 years ago (2016-12-20 19:03:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594763002/20001
4 years ago (2016-12-20 19:03:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-20 19:10:54 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 19:14:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29c4ba7e0a2d3003db7c7c77c702ed377ab8bceb
Cr-Commit-Position: refs/heads/master@{#439864}

Powered by Google App Engine
This is Rietveld 408576698