Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1631)

Issue 2594693003: [build] Fix formatting in BUILD.gn (Closed)

Created:
4 years ago by gsathya
Modified:
4 years ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix formatting in BUILD.gn git cl format flagged this while merging Review-Url: https://codereview.chromium.org/2594693003 Cr-Commit-Position: refs/heads/master@{#41875} Committed: https://chromium.googlesource.com/v8/v8/+/902a2f42e3744d64f0cb1192eb91151574d0d86d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
gsathya
4 years ago (2016-12-20 21:02:35 UTC) #6
adamk
lgtm
4 years ago (2016-12-20 22:51:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594693003/1
4 years ago (2016-12-20 22:53:34 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-20 22:55:56 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/902a2f42e3744d64f0cb1192eb91151574d...

Powered by Google App Engine
This is Rietveld 408576698