Fix the performance issuse called by last CL.

Fix the performance issuse called by last CL.

Adding superclusters into m_potentiallyInconsistentSuperclusters too frequently caused this issuse.

Try to reduce unnecessary adding in these two ways:

1. skip everHadLayout blocks in record.
2. skip UnknownAmountOfText superclusters

BUG=675534
Committed: https://crrev.com/340893b524c359dbd40b7ad656e9a6c8240724e4
Cr-Commit-Position: refs/heads/master@{#440026}

[cathiechentx, 2016-12-20 12:59:13]

Description was changed from

==========
Fix the performance issuse called by last CL.

Adding superclusters into m_potentiallyInconsistentSuperclusters too frequently
caused this issuse.

I try to reduce unnecessary adding in these two ways.

1. skip everHadLayout blocks in record.
2. skip UnknownAmountOfText superclusters

BUG=675534
==========

to

==========
Fix the performance issuse called by last CL.

Adding superclusters into m_potentiallyInconsistentSuperclusters too frequently
caused this issuse.

Try to reduce unnecessary adding in these two ways:

1. skip everHadLayout blocks in record.
2. skip UnknownAmountOfText superclusters

BUG=675534
==========

[cathiechentx, 2016-12-20 12:59:13]

cathiechen@tencent.com changed reviewers:
+ jamesxwei@tencent.com, jasontiller@google.com, pdr@chromium.org,
skobes@chromium.org

[cathiechentx, 2016-12-20 13:00:15]

Fix the performance issuse called by inconsistent CL.

[cathiechentx, 2016-12-20 13:07:26]

https://codereview.chromium.org/2594673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/TextAutosizer.cpp (right):

https://codereview.chromium.org/2594673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/TextAutosizer.cpp:334: if
(!block->everHadLayout())
No need to deal with block if block isn't new.

https://codereview.chromium.org/2594673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/TextAutosizer.cpp:566:
supercluster->m_hasEnoughTextToAutosize == NotEnoughText))
Just add the new supercluster into m_potentiallyInconsistentSuperclusters once.

[skobes, 2016-12-20 23:44:23]

lgtm with nit

https://codereview.chromium.org/2594673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/TextAutosizer.h (right):

https://codereview.chromium.org/2594673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/TextAutosizer.h:237: Supercluster*
createSuperclusterIfNeeded(LayoutBlock*, bool&);
include the parameter name when it is not obvious from the type

[cathiechentx, 2016-12-21 02:56:43]

https://codereview.chromium.org/2594673002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/TextAutosizer.h (right):

https://codereview.chromium.org/2594673002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/TextAutosizer.h:237: Supercluster*
createSuperclusterIfNeeded(LayoutBlock*, bool&);
On 2016/12/20 23:44:23, skobes wrote:
> include the parameter name when it is not obvious from the type

Done.

[cathiechentx, 2016-12-21 02:56:50]

The CQ bit was checked by cathiechen@tencent.com

[cathiechentx, 2016-12-21 02:56:50]

The patchset sent to the CQ was uploaded after l-g-t-m from skobes@chromium.org
Link to the patchset: https://codereview.chromium.org/2594673002/#ps20001
(title: "add parameter name")

[commit-bot: I haz the power, 2016-12-21 02:57:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 05:16:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482289010113340,
"parent_rev": "ecb84401c56afce589cde1c037f29c7c5e29578f", "commit_rev":
"324f67d203df11e3e22a9966ef8e36ed7cfbaf3c"}

[commit-bot: I haz the power, 2016-12-21 05:16:31]

Description was changed from

==========
Fix the performance issuse called by last CL.

Adding superclusters into m_potentiallyInconsistentSuperclusters too frequently
caused this issuse.

Try to reduce unnecessary adding in these two ways:

1. skip everHadLayout blocks in record.
2. skip UnknownAmountOfText superclusters

BUG=675534
==========

to

==========
Fix the performance issuse called by last CL.

Adding superclusters into m_potentiallyInconsistentSuperclusters too frequently
caused this issuse.

Try to reduce unnecessary adding in these two ways:

1. skip everHadLayout blocks in record.
2. skip UnknownAmountOfText superclusters

BUG=675534

Review-Url: https://codereview.chromium.org/2594673002
==========

[commit-bot: I haz the power, 2016-12-21 05:16:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 05:18:52]

Description was changed from

==========
Fix the performance issuse called by last CL.

Adding superclusters into m_potentiallyInconsistentSuperclusters too frequently
caused this issuse.

Try to reduce unnecessary adding in these two ways:

1. skip everHadLayout blocks in record.
2. skip UnknownAmountOfText superclusters

BUG=675534

Review-Url: https://codereview.chromium.org/2594673002
==========

to

==========
Fix the performance issuse called by last CL.

Adding superclusters into m_potentiallyInconsistentSuperclusters too frequently
caused this issuse.

Try to reduce unnecessary adding in these two ways:

1. skip everHadLayout blocks in record.
2. skip UnknownAmountOfText superclusters

BUG=675534

Committed: https://crrev.com/340893b524c359dbd40b7ad656e9a6c8240724e4
Cr-Commit-Position: refs/heads/master@{#440026}
==========

[commit-bot: I haz the power, 2016-12-21 05:18:53]

Patchset 2 (id:??) landed as
https://crrev.com/340893b524c359dbd40b7ad656e9a6c8240724e4
Cr-Commit-Position: refs/heads/master@{#440026}