objects.h splitting: Split out ScopeInfo + add necessary structures.

objects.h splitting: Split out ScopeInfo + add necessary structures.

See tracking bug for more information.

BUG=v8:5402
Review-Url: https://codereview.chromium.org/2594663002
Cr-Commit-Position: refs/heads/master@{#41861}
Committed: https://chromium.googlesource.com/v8/v8/+/a48e5ab8804e9e97b5ea577d6f2667bacee92eb2

[marja, 2016-12-20 12:52:57]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 12:53:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2016-12-20 13:11:37]

cbruni@chromium.org changed reviewers:
+ cbruni@chromium.org

[Camillo Bruni, 2016-12-20 13:11:38]

I like. LGTM

https://codereview.chromium.org/2594663002/diff/20001/src/objects/object-macr...
File src/objects/object-macros-undef.h (right):

https://codereview.chromium.org/2594663002/diff/20001/src/objects/object-macr...
src/objects/object-macros-undef.h:8: #undef DECLARE_CAST
Ensuring the undeffing would make a perfect presubmit check :)

[Benedikt Meurer, 2016-12-20 13:18:38]

Description was changed from

==========
objects.h splitting: Split out ScopeInfo + add necessary structures.

See tracking bug for more information.

v8:5402

BUG=
==========

to

==========
objects.h splitting: Split out ScopeInfo + add necessary structures.

See tracking bug for more information.

BUG=v8:5402
==========

[Benedikt Meurer, 2016-12-20 13:20:49]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-12-20 13:20:49]

lgtm

[marja, 2016-12-20 13:36:08]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 13:36:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2016-12-20 13:39:24]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-12-20 13:39:24]

lgtm

[marja, 2016-12-20 13:40:27]

thanks!

as discussed offline: I removed scope-info-inl.h as it was unnecessary

I'll add a todo about enforcing the undeffing into the design doc

[marja, 2016-12-20 13:40:48]

The CQ bit was unchecked by marja@chromium.org

[marja, 2016-12-20 13:40:52]

The CQ bit was checked by marja@chromium.org

[marja, 2016-12-20 13:40:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2594663002/#ps40001
(title: "scope-info.h iwyu + remove scope-info-inl.h")

[commit-bot: I haz the power, 2016-12-20 13:40:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 14:08:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482241252350960,
"parent_rev": "9feefafa66cdfcc3bdb90d9308d028cedfe22916", "commit_rev":
"a48e5ab8804e9e97b5ea577d6f2667bacee92eb2"}

[commit-bot: I haz the power, 2016-12-20 14:08:25]

Description was changed from

==========
objects.h splitting: Split out ScopeInfo + add necessary structures.

See tracking bug for more information.

BUG=v8:5402
==========

to

==========
objects.h splitting: Split out ScopeInfo + add necessary structures.

See tracking bug for more information.

BUG=v8:5402

Review-Url: https://codereview.chromium.org/2594663002
Cr-Commit-Position: refs/heads/master@{#41861}
Committed:
https://chromium.googlesource.com/v8/v8/+/a48e5ab8804e9e97b5ea577d6f2667bacee...
==========

[commit-bot: I haz the power, 2016-12-20 14:08:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a48e5ab8804e9e97b5ea577d6f2667bacee...