Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2594603002: Add a GN option to use Chromium style naming with the Blink GC plugin. (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews, haraken, sof, Ɓukasz Anforowicz, nasko
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GN option to use Chromium style naming with the Blink GC plugin. BUG=584538 Committed: https://crrev.com/ec7c92dfb57e631d3c249c265e6e757afad2d039 Cr-Commit-Position: refs/heads/master@{#439885}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M third_party/WebKit/Source/BUILD.gn View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
dcheng
The actual plugin change is in https://codereview.chromium.org/2578103003/, and not yet landed/rolled. However, landing this now ...
4 years ago (2016-12-20 09:00:56 UTC) #2
Dirk Pranke
lgtm
4 years ago (2016-12-20 21:27:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594603002/1
4 years ago (2016-12-20 21:35:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-20 21:41:57 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-20 21:44:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ec7c92dfb57e631d3c249c265e6e757afad2d039
Cr-Commit-Position: refs/heads/master@{#439885}

Powered by Google App Engine
This is Rietveld 408576698