Revert of [views] Changes iteration over |children_| to use range-based for loops

Revert of [views] Changes iteration over |children_| to use range-based for loops (patchset #2 id:20001 of https://codereview.chromium.org/2583343003/ )

Reason for revert:
The following three tests on sync_integration_tests failed by this CL:
 TwoClientThemesSyncTest.CustomThenSyncNative_E2ETest
 TwoClientThemesSyncTest.CycleOptions_E2ETest
 SingleClientThemesSyncTest.NativeTheme

This patch changed to use iterator instead of [] operator, but |children_| seems to be changed somewhere during the iteration.

Original issue's description:
> [views] Changes iteration over |children_| to use range-based for loops
>
> BUG=NONE
> TEST=covered by existing tests
>
> Committed: https://crrev.com/ebc65542d481179168a67b83a3151da26daaaa54
> Cr-Commit-Position: refs/heads/master@{#439909}

TBR=sadrul@chromium.org,ben@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Committed: https://crrev.com/edbb6aaf0bce84755ba4e06b1061b95918eebe67
Cr-Commit-Position: refs/heads/master@{#440007}

[shimazu, 2016-12-21 04:01:55]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2016-12-21 04:01:55]

Created Revert of [views] Changes iteration over |children_| to use range-based
for loops

[commit-bot: I haz the power, 2016-12-21 04:02:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 04:02:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482292915160960, "parent_rev":
"59bec84ecf47d4385cfefd026a7845efa71a1f81", "commit_rev":
"7926b93e548c5c045022044335ee37464ca454ac"}

[commit-bot: I haz the power, 2016-12-21 04:03:12]

Description was changed from

==========
Revert of [views] Changes iteration over |children_| to use range-based for
loops (patchset #2 id:20001 of https://codereview.chromium.org/2583343003/ )

Reason for revert:
The following three tests on sync_integration_tests failed by this CL:
 TwoClientThemesSyncTest.CustomThenSyncNative_E2ETest
 TwoClientThemesSyncTest.CycleOptions_E2ETest
 SingleClientThemesSyncTest.NativeTheme
 
This patch changed to use iterator instead of [] operator, but |children_| seems
to be changed somewhere during the iteration.

Original issue's description:
> [views] Changes iteration over |children_| to use range-based for loops
> 
> BUG=NONE
> TEST=covered by existing tests
> 
> Committed: https://crrev.com/ebc65542d481179168a67b83a3151da26daaaa54
> Cr-Commit-Position: refs/heads/master@{#439909}

TBR=sadrul@chromium.org,ben@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE
==========

to

==========
Revert of [views] Changes iteration over |children_| to use range-based for
loops (patchset #2 id:20001 of https://codereview.chromium.org/2583343003/ )

Reason for revert:
The following three tests on sync_integration_tests failed by this CL:
 TwoClientThemesSyncTest.CustomThenSyncNative_E2ETest
 TwoClientThemesSyncTest.CycleOptions_E2ETest
 SingleClientThemesSyncTest.NativeTheme
 
This patch changed to use iterator instead of [] operator, but |children_| seems
to be changed somewhere during the iteration.

Original issue's description:
> [views] Changes iteration over |children_| to use range-based for loops
> 
> BUG=NONE
> TEST=covered by existing tests
> 
> Committed: https://crrev.com/ebc65542d481179168a67b83a3151da26daaaa54
> Cr-Commit-Position: refs/heads/master@{#439909}

TBR=sadrul@chromium.org,ben@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review-Url: https://codereview.chromium.org/2594533003
==========

[commit-bot: I haz the power, 2016-12-21 04:03:13]

Committed patchset #1 (id:1)

[sadrul, 2016-12-21 04:03:59]

Is there a link to the failure with logs/stacktraces etc.?

[commit-bot: I haz the power, 2016-12-21 04:05:51]

Description was changed from

==========
Revert of [views] Changes iteration over |children_| to use range-based for
loops (patchset #2 id:20001 of https://codereview.chromium.org/2583343003/ )

Reason for revert:
The following three tests on sync_integration_tests failed by this CL:
 TwoClientThemesSyncTest.CustomThenSyncNative_E2ETest
 TwoClientThemesSyncTest.CycleOptions_E2ETest
 SingleClientThemesSyncTest.NativeTheme
 
This patch changed to use iterator instead of [] operator, but |children_| seems
to be changed somewhere during the iteration.

Original issue's description:
> [views] Changes iteration over |children_| to use range-based for loops
> 
> BUG=NONE
> TEST=covered by existing tests
> 
> Committed: https://crrev.com/ebc65542d481179168a67b83a3151da26daaaa54
> Cr-Commit-Position: refs/heads/master@{#439909}

TBR=sadrul@chromium.org,ben@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Review-Url: https://codereview.chromium.org/2594533003
==========

to

==========
Revert of [views] Changes iteration over |children_| to use range-based for
loops (patchset #2 id:20001 of https://codereview.chromium.org/2583343003/ )

Reason for revert:
The following three tests on sync_integration_tests failed by this CL:
 TwoClientThemesSyncTest.CustomThenSyncNative_E2ETest
 TwoClientThemesSyncTest.CycleOptions_E2ETest
 SingleClientThemesSyncTest.NativeTheme

This patch changed to use iterator instead of [] operator, but |children_| seems
to be changed somewhere during the iteration.

Original issue's description:
> [views] Changes iteration over |children_| to use range-based for loops
>
> BUG=NONE
> TEST=covered by existing tests
>
> Committed: https://crrev.com/ebc65542d481179168a67b83a3151da26daaaa54
> Cr-Commit-Position: refs/heads/master@{#439909}

TBR=sadrul@chromium.org,ben@chromium.org,varkha@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=NONE

Committed: https://crrev.com/edbb6aaf0bce84755ba4e06b1061b95918eebe67
Cr-Commit-Position: refs/heads/master@{#440007}
==========

[commit-bot: I haz the power, 2016-12-21 04:05:51]

Patchset 1 (id:??) landed as
https://crrev.com/edbb6aaf0bce84755ba4e06b1061b95918eebe67
Cr-Commit-Position: refs/heads/master@{#440007}

[shimazu, 2016-12-21 04:05:56]

On 2016/12/21 04:03:59, sadrul wrote:
> Is there a link to the failure with logs/stacktraces etc.?

Yes! This is a link to the build log:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%...