Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2594493002: offset-rotate: Clamp rotation to float prior to assignment (Closed)

Created:
4 years ago by alancutter (OOO until 2018)
Modified:
4 years ago
Reviewers:
sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

offset-rotate: Clamp rotation to float prior to assignment This change moves a clampTo<float>() call to before float assignment rather than after. This is intended to keep float overflow detection happy and has no behavioural changes. BUG=675558 Committed: https://crrev.com/ea473ab14a34a428db2ff8bbcb75e3378530e3a4 Cr-Commit-Position: refs/heads/master@{#439962}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
alancutter (OOO until 2018)
4 years ago (2016-12-20 05:46:57 UTC) #3
sashab
Nice!! LGTM https://codereview.chromium.org/2594493002/diff/1/third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html File third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html (right): https://codereview.chromium.org/2594493002/diff/1/third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html#newcode5 third_party/WebKit/LayoutTests/css3/motion-path/motion-rotation-overflow-crash.html:5: offset: path("M 2 9223372036854775640 h 112 v ...
4 years ago (2016-12-20 22:36:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594493002/1
4 years ago (2016-12-20 23:42:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 01:17:45 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-21 01:19:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea473ab14a34a428db2ff8bbcb75e3378530e3a4
Cr-Commit-Position: refs/heads/master@{#439962}

Powered by Google App Engine
This is Rietveld 408576698