Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2594423002: Verify that FetchEvent::m_request holds same-thread reference. (Closed)

Created:
4 years ago by sof
Modified:
4 years ago
Reviewers:
haraken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify that FetchEvent::m_request holds same-thread reference. To diagnose instability seen during GCs of FetchEvents, instrument the m_request member, checking that we only create event object containing references to Requests that reside in the current thread's heap. R= BUG=655926 Committed: https://crrev.com/3d5b1a43aeb21176af2d264d8ec399916e29c4cd Cr-Commit-Position: refs/heads/master@{#440475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
sof
please take a look. Same theory for this one as in https://codereview.chromium.org/2589333005/ - m_request ends ...
4 years ago (2016-12-22 16:43:06 UTC) #4
haraken
LGTM
4 years ago (2016-12-22 17:35:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594423002/1
4 years ago (2016-12-22 19:41:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 19:45:58 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-22 19:48:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d5b1a43aeb21176af2d264d8ec399916e29c4cd
Cr-Commit-Position: refs/heads/master@{#440475}

Powered by Google App Engine
This is Rietveld 408576698