Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2594373003: [Android] Flip the NDK Next builders to clang. (Closed)

Created:
4 years ago by jbudorick
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Flip the NDK Next builders to clang. The r13 release notes [1] say that GCC is no longer supported. Currently, compilation with GCC is broken on ambiguous unique_ptr / int issues that I haven't yet been able to figure out. [1] https://github.com/android-ndk/ndk/wiki/Changelog-r13 BUG=668202 TBR=dpranke@chromium.org Committed: https://crrev.com/15cc6b41daf2500026449b9d9bcf463b2e8dcfc3 Cr-Commit-Position: refs/heads/master@{#440435}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/mb/mb_config.pyl View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jbudorick
TBR: fix for FYI bots
4 years ago (2016-12-22 14:57:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594373003/1
4 years ago (2016-12-22 14:57:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 16:10:46 UTC) #8
Dirk Pranke
lgtm
4 years ago (2016-12-22 16:13:10 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-22 16:13:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15cc6b41daf2500026449b9d9bcf463b2e8dcfc3
Cr-Commit-Position: refs/heads/master@{#440435}

Powered by Google App Engine
This is Rietveld 408576698