Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2594313002: Update layout after TypingCommand::willAddTypingToOpenCommand (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
CC:
blink-reviews, chongz, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update layout after TypingCommand::willAddTypingToOpenCommand This patch is a preparation for https://crrev.com/2558643003, where TypingCommand::willAddTypingToOpenCommand is modified to fire 'beforeinput' event. Since the event handler may make layout dirty and all follow-up operations require clean layout, this patch adds layout update after TypingCommand::willAddTypingToOpenCommand finishes. BUG=670035 Committed: https://crrev.com/52e388599d4d76546635b462a534e08dca4ff104 Cr-Commit-Position: refs/heads/master@{#440387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 7 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-22 07:53:46 UTC) #7
dominicc (has gone to gerrit)
lgtm
4 years ago (2016-12-22 11:47:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594313002/1
4 years ago (2016-12-22 11:47:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 11:51:01 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/52e388599d4d76546635b462a534e08dca4ff104 Cr-Commit-Position: refs/heads/master@{#440387}
4 years ago (2016-12-22 11:52:46 UTC) #15
chongz
3 years, 11 months ago (2017-01-16 16:17:21 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2634133002/ by chongz@chromium.org.

The reason for reverting is: Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789..

Powered by Google App Engine
This is Rietveld 408576698