Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2594303002: MD History: Fix broken sync status dropdown (Closed)

Created:
4 years ago by tsergeant
Modified:
3 years, 11 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Fix broken sync status dropdown The sync (i) icon in the top-right of the page uses the iron-dropdown Polymer element to display its content. This element was implicitly imported by cr-shared-menu, meaning that after cr-shared-menu was removed (in crrev.com/440308) from the history page, the dropdown stopped working. This CL restores the import of iron-dropdown, fixing the dropdown. BUG=658821 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8fa5f27bcd9f3348c8344e0b0728dd7f936bbfc4 Cr-Commit-Position: refs/heads/master@{#440815}

Patch Set 1 #

Patch Set 2 : All your rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1 line) Patch
M chrome/browser/resources/md_history/lazy_load.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_history/lazy_load.crisper.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
tsergeant
Next step is to remove the dependency on iron-dropdown. The sync status icon is the ...
4 years ago (2016-12-22 03:23:06 UTC) #5
calamity
lgtm
4 years ago (2016-12-22 05:07:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594303002/1
4 years ago (2016-12-22 05:07:24 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/md_history/app.vulcanized.html: While running git apply --index -p1; <stdin>:106: trailing whitespace. ...
4 years ago (2016-12-22 05:16:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594303002/20001
3 years, 12 months ago (2016-12-27 23:48:09 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 12 months ago (2016-12-28 00:42:08 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:48:04 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8fa5f27bcd9f3348c8344e0b0728dd7f936bbfc4
Cr-Commit-Position: refs/heads/master@{#440815}

Powered by Google App Engine
This is Rietveld 408576698