Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Unified Diff: content/browser/accessibility/accessibility_tree_formatter.cc

Issue 25943003: Support accessible inline text boxes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/accessibility_tree_formatter.cc
diff --git a/content/browser/accessibility/accessibility_tree_formatter.cc b/content/browser/accessibility/accessibility_tree_formatter.cc
index 4368cf132179b383932f018e4f667f2153fece95..cde18862c4a8fdf75415cf31caa3ec23b837ed12 100644
--- a/content/browser/accessibility/accessibility_tree_formatter.cc
+++ b/content/browser/accessibility/accessibility_tree_formatter.cc
@@ -66,7 +66,7 @@ void AccessibilityTreeFormatter::RecursiveBuildAccessibilityTree(
base::ListValue* children = new base::ListValue;
dict->Set(kChildrenDictAttr, children);
- if (!IncludeChildren(node))
+ if (node.IsLeaf())
David Tseng 2013/10/17 22:56:29 Btw, isLeaf worries me because it's often possible
dmazzoni 2013/10/21 17:26:57 My intent is that this is only used to really mean
return;
for (size_t i = 0; i < node.children().size(); ++i) {
@@ -93,13 +93,6 @@ void AccessibilityTreeFormatter::RecursiveFormatAccessibilityTree(
}
}
-#if !defined(OS_ANDROID)
-bool AccessibilityTreeFormatter::IncludeChildren(
- const BrowserAccessibility& node) {
- return true;
-}
-#endif
-
#if (!defined(OS_WIN) && !defined(OS_MACOSX) && !defined(OS_ANDROID) && \
!defined(TOOLKIT_GTK))
void AccessibilityTreeFormatter::AddProperties(const BrowserAccessibility& node,

Powered by Google App Engine
This is Rietveld 408576698