Support accessible inline text boxes.

content/browser/accessibility/accessibility_tree_formatter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/accessibility_tree_formatter.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
@@ skipping 48 matching lines @@
   scoped_ptr<base::DictionaryValue> dict = BuildAccessibilityTree();
   RecursiveFormatAccessibilityTree(*(dict.get()), contents);
 }
 
 void AccessibilityTreeFormatter::RecursiveBuildAccessibilityTree(
     const BrowserAccessibility& node, base::DictionaryValue* dict) {
   AddProperties(node, dict);
 
   base::ListValue* children = new base::ListValue;
   dict->Set(kChildrenDictAttr, children);
-  if (!IncludeChildren(node))
+  if (node.IsLeaf())

[David Tseng, 2013/10/17 22:56:29]

Btw, isLeaf worries me because it's often possible to get focus set on a
descendant of a leaf (depending on how we define leaves). We should be careful
when stating what is a leaf and what isn't.

[dmazzoni, 2013/10/21 17:26:57]

My intent is that this is only used to really mean a leaf - we literally don't
expose any children of this node to the platform. On Android, we sometimes prune
children of a focusable node that has a title, but we're careful to only do this
when it doesn't itself have any focusable children - so there isn't any worry
about this.

Would some documentation help, or can you think of a better name?

     return;
 
   for (size_t i = 0; i < node.children().size(); ++i) {
     BrowserAccessibility* child_node = node.children()[i];
     base::DictionaryValue* child_dict = new base::DictionaryValue;
     children->Append(child_dict);
     RecursiveBuildAccessibilityTree(*child_node, child_dict);
   }
 }
 
 void AccessibilityTreeFormatter::RecursiveFormatAccessibilityTree(
     const base::DictionaryValue& dict, string16* contents, int depth) {
   string16 line = ToString(dict, string16(depth * kIndentSpaces, ' '));
   if (line.find(ASCIIToUTF16(kSkipString)) != string16::npos)
     return;
 
   *contents += line;
   const base::ListValue* children;
   dict.GetList(kChildrenDictAttr, &children);
   const base::DictionaryValue* child_dict;
   for (size_t i = 0; i < children->GetSize(); i++) {
     children->GetDictionary(i, &child_dict);
     RecursiveFormatAccessibilityTree(*child_dict, contents, depth + 1);
   }
 }
 
-#if !defined(OS_ANDROID)
-bool AccessibilityTreeFormatter::IncludeChildren(
-    const BrowserAccessibility& node) {
-  return true;
-}
-#endif
-
 #if (!defined(OS_WIN) && !defined(OS_MACOSX) && !defined(OS_ANDROID) && \
      !defined(TOOLKIT_GTK))
 void AccessibilityTreeFormatter::AddProperties(const BrowserAccessibility& node,
                                                base::DictionaryValue* dict) {
   dict->SetInteger("id", node.renderer_id());
 }
 
 string16 AccessibilityTreeFormatter::ToString(const base::DictionaryValue& node,
                                               const string16& indent) {
   int id_value;
@@ skipping 75 matching lines @@
   if (attr.empty())
     return;
   if (!MatchesFilters(attr, include_by_default))
     return;
   if (!line->empty())
     *line += ASCIIToUTF16(" ");
   *line += attr;
 }
 
 }  // namespace content