Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2594243002: Add flag to make vda_unittest input paths relative to media/test/data (Closed)

Created:
3 years, 12 months ago by jbauman
Modified:
3 years, 12 months ago
Reviewers:
watk
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag to make vda_unittest input paths relative to media/test/data On ChromeOS the test launcher specifies the paths as absolute paths or relative to the CWD. On the GPU bots they need to be specified relative to the source root, so add the --use-test-data-path flag for that. BUG=676053 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/de22f3cd6cbaeb347cd317629ca8528bf63da152 Cr-Commit-Position: refs/heads/master@{#440481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M media/gpu/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M media/gpu/video_decode_accelerator_unittest.cc View 6 chunks +20 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jbauman
3 years, 12 months ago (2016-12-22 00:38:07 UTC) #5
watk
lgtm
3 years, 12 months ago (2016-12-22 19:44:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594243002/1
3 years, 12 months ago (2016-12-22 19:59:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-22 20:03:29 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-22 20:05:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de22f3cd6cbaeb347cd317629ca8528bf63da152
Cr-Commit-Position: refs/heads/master@{#440481}

Powered by Google App Engine
This is Rietveld 408576698