Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2594233002: Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. (Closed)

Created:
4 years ago by Zhenyao Mo
Modified:
4 years ago
Reviewers:
vmiura, ericrk
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Change GetIntegerv(IMPLEMENTATION_COLOR_READ_FORMAT/TYPE) behavior. 1) Clean up a bit mess with framebuffer target 2) On desktop GL, no longer query the driver for these two enums. The drivers won't provide the answers anyway. Instead, use internal logic to determine the format/type BUG=662802 TEST=gpu_unittests,webgl_conformance R=vmiura@chromium.org,ericrk@chromium.org NOTRY=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2577293002 Cr-Commit-Position: refs/heads/master@{#439206} (cherry picked from commit a11bcfb22a66f56d8a885efd89e7979d60d638b4) Committed: https://chromium.googlesource.com/chromium/src/+/ca5a6fb3e2be3f4da8329090e906c0d5fa1b7820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -109 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 2 chunks +7 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 30 chunks +86 lines, -94 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Zhenyao Mo
4 years ago (2016-12-22 00:27:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ca5a6fb3e2be3f4da8329090e906c0d5fa1b7820.

Powered by Google App Engine
This is Rietveld 408576698