Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2594203003: Mark function-generator-details as NeedsRebaseline (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
kozy
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark function-generator-details as NeedsRebaseline The relevant change to display scopes for suspended generator objects has now landed in V8. BUG=chromium:667286 Committed: https://crrev.com/d13f0d91b1f707e76dd475be962b5813ab7e764b Cr-Commit-Position: refs/heads/master@{#440398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
4 years ago (2016-12-22 12:03:07 UTC) #4
kozy
lgtm
4 years ago (2016-12-22 12:18:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594203003/1
4 years ago (2016-12-22 12:19:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 13:04:15 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-22 13:06:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d13f0d91b1f707e76dd475be962b5813ab7e764b
Cr-Commit-Position: refs/heads/master@{#440398}

Powered by Google App Engine
This is Rietveld 408576698