Remove CFX_ArrayTemplate, use unique_ptr in fpdfsdk/pdfwindow

Remove CFX_ArrayTemplate, use unique_ptr in fpdfsdk/pdfwindow

Review-Url: https://codereview.chromium.org/2594153003
Committed: https://pdfium.googlesource.com/pdfium/+/6745f96fab41e2b46f57a3717b034a4064c0de02

[Tom Sepez, 2016-12-21 22:48:47]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 22:48:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-12-21 22:55:31]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-12-21 22:55:32]

https://codereview.chromium.org/2594153003/diff/20001/fpdfsdk/pdfwindow/PWL_W...
File fpdfsdk/pdfwindow/PWL_Wnd.cpp (right):

https://codereview.chromium.org/2594153003/diff/20001/fpdfsdk/pdfwindow/PWL_W...
fpdfsdk/pdfwindow/PWL_Wnd.cpp:503: m_Children.erase(std::next(it).base());
Apparently, this is the convert reverse to forward iterator idiom.

[dsinclair, 2017-01-02 17:58:16]

dsinclair@chromium.org changed reviewers:
+ dsinclair@chromium.org

[dsinclair, 2017-01-02 17:58:17]

https://codereview.chromium.org/2594153003/diff/40001/fpdfsdk/pdfwindow/PWL_W...
File fpdfsdk/pdfwindow/PWL_Wnd.cpp (right):

https://codereview.chromium.org/2594153003/diff/40001/fpdfsdk/pdfwindow/PWL_W...
fpdfsdk/pdfwindow/PWL_Wnd.cpp:277: *it = nullptr;
Why do we need to set the thing the iterator points to to a nullptr?

https://codereview.chromium.org/2594153003/diff/40001/fpdfsdk/pdfwindow/PWL_W...
fpdfsdk/pdfwindow/PWL_Wnd.cpp:503: m_Children.erase(std::next(it).base());
Why do we need std::next here? Don't we want to remove it?

[Tom Sepez, 2017-01-03 22:11:28]

https://codereview.chromium.org/2594153003/diff/40001/fpdfsdk/pdfwindow/PWL_W...
File fpdfsdk/pdfwindow/PWL_Wnd.cpp (right):

https://codereview.chromium.org/2594153003/diff/40001/fpdfsdk/pdfwindow/PWL_W...
fpdfsdk/pdfwindow/PWL_Wnd.cpp:277: *it = nullptr;
On 2017/01/02 17:58:17, dsinclair wrote:
> Why do we need to set the thing the iterator points to to a nullptr?

Because we're not actually removing the element from m_Childern, so I want to
keep it consistent at least until the clear below in case OnNotify somehow
enters one of these methods.

[dsinclair, 2017-01-04 14:16:38]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2017-01-04 14:16:39]

lgtm

[commit-bot: I haz the power, 2017-01-04 14:16:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 14:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 14:18:35]

Try jobs failed on following builders:
  android on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/android/builds/...)
  linux_asan_lsan on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_asan_lsan...)
  mac_xfa_rel on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_xfa_rel/bui...)

[Tom Sepez, 2017-01-04 17:56:14]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2017-01-04 17:56:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2594153003/#ps60001
(title: "Fix compilation")

[commit-bot: I haz the power, 2017-01-04 17:56:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 18:09:45]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483552574845160,
"parent_rev": "fff400a5df032c2203eef9f76a5dbb164672df3d", "commit_rev":
"6745f96fab41e2b46f57a3717b034a4064c0de02"}

[commit-bot: I haz the power, 2017-01-04 18:09:47]

Description was changed from

==========
Remove CFX_ArrayTemplate, use unique_ptr in fpdfsdk/pdfwindow
==========

to

==========
Remove CFX_ArrayTemplate, use unique_ptr in fpdfsdk/pdfwindow

Review-Url: https://codereview.chromium.org/2594153003
Committed:
https://pdfium.googlesource.com/pdfium/+/6745f96fab41e2b46f57a3717b034a4064c0...
==========

[commit-bot: I haz the power, 2017-01-04 18:09:49]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6745f96fab41e2b46f57a3717b034a4064c0...