Fix conditional for /OPT:ICF so Debug non-component build does not warn.

Fix conditional for /OPT:ICF so Debug non-component build does not warn.

The condition under which /OPT:ICF was enabled was out-of-sync with the
conditions for enabling incremental linking. Since the two are not
compatible the difference resulted in linker warnings in Debug
non-component builds.

BUG=621236, 659007
Committed: https://crrev.com/f6aa9ef3cd873f0cb097e3621f262c72a3876c7d
Cr-Commit-Position: refs/heads/master@{#440514}

[Wez, 2016-12-21 22:31:48]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 22:32:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wez, 2016-12-21 22:36:04]

wez@chromium.org changed reviewers:
+ brucedawson@chromium.org

[Wez, 2016-12-21 22:36:04]

PTAL

Most targets seemingly get their ldflags from the conditional in
build/config/win/BUILD.gn, but mkpeephole gets them from
build/config/compiler/BUILD.gn.  At the same time, mkpeephole still seems to get
the win/BUILD.gn incremental linker options, leading to conflicts.

Still not sure why this doesn't break more targets in Debug non-component
builds. :-/

[commit-bot: I haz the power, 2016-12-22 01:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 01:05:28]

Dry run: This issue passed the CQ dry run.

[Wez, 2016-12-22 18:52:21]

Ping!

As per discussion on the bug, this issue occurs because all v8 targets are
configured with optimize_max/speed, whereas Chromium targets do so only for
non-debug builds.

[brucedawson, 2016-12-22 19:50:42]

I would also say that /OPT:ICF doesn't make sense for debug builds. In fact, I
would say that it is actively harmful. /OPT:ICF leads to confusion (unexpected
functions showing up in call stacks) which is the opposite of what debug builds
should be.

So, maybe strengthen/adjust your comment to mention that /OPT:ICF is
inadvisable/undesirable/unwanted for debug builds. But either way, lgtm. Thanks!

[Wez, 2016-12-22 20:40:39]

The CQ bit was checked by wez@chromium.org

[Wez, 2016-12-22 20:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/2594153002/#ps20001
(title: "Improve comment")

[commit-bot: I haz the power, 2016-12-22 20:41:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 21:46:20]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482439239285520,
"parent_rev": "00d56bf2d98e6d469789a784d8a14a322e4e1e92", "commit_rev":
"d7f450e68e78fcb47624d37f6aba3d98bf4ede64"}

[commit-bot: I haz the power, 2016-12-22 21:46:51]

Description was changed from

==========
Fix conditional for /OPT:ICF so Debug non-component build does not warn.

The condition under which /OPT:ICF was enabled was out-of-sync with the
conditions for enabling incremental linking. Since the two are not
compatible the difference resulted in linker warnings in Debug
non-component builds.

BUG=621236, 659007
==========

to

==========
Fix conditional for /OPT:ICF so Debug non-component build does not warn.

The condition under which /OPT:ICF was enabled was out-of-sync with the
conditions for enabling incremental linking. Since the two are not
compatible the difference resulted in linker warnings in Debug
non-component builds.

BUG=621236, 659007

Review-Url: https://codereview.chromium.org/2594153002
==========

[commit-bot: I haz the power, 2016-12-22 21:46:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-22 21:51:17]

Description was changed from

==========
Fix conditional for /OPT:ICF so Debug non-component build does not warn.

The condition under which /OPT:ICF was enabled was out-of-sync with the
conditions for enabling incremental linking. Since the two are not
compatible the difference resulted in linker warnings in Debug
non-component builds.

BUG=621236, 659007

Review-Url: https://codereview.chromium.org/2594153002
==========

to

==========
Fix conditional for /OPT:ICF so Debug non-component build does not warn.

The condition under which /OPT:ICF was enabled was out-of-sync with the
conditions for enabling incremental linking. Since the two are not
compatible the difference resulted in linker warnings in Debug
non-component builds.

BUG=621236, 659007

Committed: https://crrev.com/f6aa9ef3cd873f0cb097e3621f262c72a3876c7d
Cr-Commit-Position: refs/heads/master@{#440514}
==========

[commit-bot: I haz the power, 2016-12-22 21:51:18]

Patchset 2 (id:??) landed as
https://crrev.com/f6aa9ef3cd873f0cb097e3621f262c72a3876c7d
Cr-Commit-Position: refs/heads/master@{#440514}