Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2594093002: Re-arrange some null pointer checks in HTMLCanvasElement.cpp (Closed)

Created:
4 years ago by Justin Novosad
Modified:
4 years ago
Reviewers:
xlai (Olivia)
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-arrange some null pointer checks in HTMLCanvasElement.cpp BUG=675099 Committed: https://crrev.com/aaee8c63e6a1716c78b5e5715e1f96b8df4ed1e3 Cr-Commit-Position: refs/heads/master@{#440231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 4 chunks +22 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Justin Novosad
PTAL
4 years ago (2016-12-21 20:32:04 UTC) #3
xlai (Olivia)
lgtm
4 years ago (2016-12-21 21:02:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2594093002/1
4 years ago (2016-12-21 21:20:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 21:59:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-21 22:04:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaee8c63e6a1716c78b5e5715e1f96b8df4ed1e3
Cr-Commit-Position: refs/heads/master@{#440231}

Powered by Google App Engine
This is Rietveld 408576698