Configure xctest build settings to prevent Xcode from linking objects.

Configure xctest build settings to prevent Xcode from linking objects.

Test files need to be known to Xcode for proper indexing and for discovery of
tests function for XCTest, but the compilation is done via ninja, which causes
Xcode fail find object files when trying to link.

This CL configures the build settings of XCTest targets to trick Xcode to
blindly return success when trying to link object files.

BUG=614818
Committed: https://crrev.com/7e5894a9a070055aec683a83d50523df7f585f38
Cr-Commit-Position: refs/heads/master@{#441500}

[liaoyuke, 2016-12-21 19:59:49]

Patchset #2 (id:20001) has been deleted

[liaoyuke, 2017-01-03 17:27:38]

Patchset #2 (id:40001) has been deleted

[liaoyuke, 2017-01-03 17:30:52]

Description was changed from

==========
Configure xctest build settings to prevent Xcode from linking objects.

Test files need to be known to Xcode for proper indexing and for discovery of
tests function for XCTest, but the compilation is done via ninja, which causes
Xcode fail find object files when trying to link.

This CL configures the build settings of XCTest targets to trick Xcode to
blindly return success when trying to link object files.

BUG=614818
==========

to

==========
Configure xctest build settings to prevent Xcode from linking objects.

Test files need to be known to Xcode for proper indexing and for discovery of
tests function for XCTest, but the compilation is done via ninja, which causes
Xcode fail find object files when trying to link.

This CL configures the build settings of XCTest targets to trick Xcode to
blindly return success when trying to link object files.

BUG=614818
==========

[liaoyuke, 2017-01-03 17:30:52]

liaoyuke@chromium.org changed reviewers:
+ justincohen@chromium.org, sdefresne@chromium.org

[liaoyuke, 2017-01-03 17:32:02]

PTAL

Thank you very much!

[sdefresne, 2017-01-04 14:10:45]

lgtm

[liaoyuke, 2017-01-04 17:18:52]

liaoyuke@chromium.org changed reviewers:
+ dpranke@chromium.org

[liaoyuke, 2017-01-04 17:19:43]

On 2017/01/04 14:10:45, sdefresne wrote:
> lgtm

Thank you for reviewing :)

Hello Dirk,

Could you please take a look for owner's approval?

Thank you very much!

[Dirk Pranke, 2017-01-04 20:25:07]

lgtm.

[liaoyuke, 2017-01-04 20:25:52]

Thank you :)

On Wed, Jan 4, 2017 at 12:25 PM <dpranke@chromium.org> wrote:

> lgtm.
>
> https://codereview.chromium.org/2594033002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[liaoyuke, 2017-01-04 22:38:40]

The CQ bit was checked by liaoyuke@chromium.org

[liaoyuke, 2017-01-04 22:38:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2594033002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-04 22:39:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 22:52:24]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483569520259000,
"parent_rev": "7605d92317b27670fe0ceaebb875ab42d129811f", "commit_rev":
"41802a43b71a75fb9f3600bc4a52b285b7d008f2"}

[commit-bot: I haz the power, 2017-01-04 22:52:50]

Description was changed from

==========
Configure xctest build settings to prevent Xcode from linking objects.

Test files need to be known to Xcode for proper indexing and for discovery of
tests function for XCTest, but the compilation is done via ninja, which causes
Xcode fail find object files when trying to link.

This CL configures the build settings of XCTest targets to trick Xcode to
blindly return success when trying to link object files.

BUG=614818
==========

to

==========
Configure xctest build settings to prevent Xcode from linking objects.

Test files need to be known to Xcode for proper indexing and for discovery of
tests function for XCTest, but the compilation is done via ninja, which causes
Xcode fail find object files when trying to link.

This CL configures the build settings of XCTest targets to trick Xcode to
blindly return success when trying to link object files.

BUG=614818

Review-Url: https://codereview.chromium.org/2594033002
==========

[commit-bot: I haz the power, 2017-01-04 22:52:51]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2017-01-04 22:57:21]

Description was changed from

==========
Configure xctest build settings to prevent Xcode from linking objects.

Test files need to be known to Xcode for proper indexing and for discovery of
tests function for XCTest, but the compilation is done via ninja, which causes
Xcode fail find object files when trying to link.

This CL configures the build settings of XCTest targets to trick Xcode to
blindly return success when trying to link object files.

BUG=614818

Review-Url: https://codereview.chromium.org/2594033002
==========

to

==========
Configure xctest build settings to prevent Xcode from linking objects.

Test files need to be known to Xcode for proper indexing and for discovery of
tests function for XCTest, but the compilation is done via ninja, which causes
Xcode fail find object files when trying to link.

This CL configures the build settings of XCTest targets to trick Xcode to
blindly return success when trying to link object files.

BUG=614818

Committed: https://crrev.com/7e5894a9a070055aec683a83d50523df7f585f38
Cr-Commit-Position: refs/heads/master@{#441500}
==========

[commit-bot: I haz the power, 2017-01-04 22:57:22]

Patchset 3 (id:??) landed as
https://crrev.com/7e5894a9a070055aec683a83d50523df7f585f38
Cr-Commit-Position: refs/heads/master@{#441500}