Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2593983003: Update TaskTraits in dom_storage_context_wrapper.cc. (Closed)

Created:
4 years ago by fdoray
Modified:
4 years ago
Reviewers:
michaeln, gab
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TaskTraits in dom_storage_context_wrapper.cc. The .WithFileIO() and .WithWait() traits were deprecated in favor of .MayBlock() and .WithSyncPrimitives(). See rationale in https://docs.google.com/a/chromium.org/document/d/1ynRvQKah3Cx_eLqPS7KzIp8u73HeKIjX7HQqwSWOnF8/edit?usp=sharing .MayBlock() Tasks with this trait may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait does not allow tasks to wait on synchronization primitives (thread or process handles, waitable events, condition variables). .WithSyncPrimitives() Tasks with this trait are allowed to block on synchronization primitives (wait on a waitable event/condition variable, join a process/thread). This trait implies MayBlock(), i.e. you do not need to specify MayBlock() for a task that blocks exclusively on synchronization primitives. R=gab@chromium.org TBR=michaeln@chromium.org BUG=675660 Committed: https://crrev.com/01a20402812b5a9e3b2f92090b9865bf5c092563 Cr-Commit-Position: refs/heads/master@{#440396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/dom_storage/dom_storage_context_wrapper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
fdoray
PTAL
4 years ago (2016-12-21 16:12:34 UTC) #4
gab
lgtm
4 years ago (2016-12-21 16:14:08 UTC) #5
fdoray
TBR=michaeln@chromium.org for a trivial search-and-replace
4 years ago (2016-12-22 12:55:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593983003/1
4 years ago (2016-12-22 12:55:39 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-22 13:00:22 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-22 13:03:54 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01a20402812b5a9e3b2f92090b9865bf5c092563
Cr-Commit-Position: refs/heads/master@{#440396}

Powered by Google App Engine
This is Rietveld 408576698