Queue custom element attribute reactions for no-op sets, removes

Queue custom element attribute reactions for no-op sets, removes

The DOM spec says to set attributes, even if their values don't
change, and it is the attribute *setting* which triggers custom
elements attributeChangedCallbacks. In hindsight that callback could
be better named.

BUG=676247
Committed: https://crrev.com/1ba3273c3c421d97ee7ca9570782874cef380275
Cr-Commit-Position: refs/heads/master@{#440334}

[dominicc (has gone to gerrit), 2016-12-21 07:53:29]

The CQ bit was checked by dominicc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 07:53:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominicc (has gone to gerrit), 2016-12-21 07:54:10]

dominicc@chromium.org changed reviewers:
+ kochi@chromium.org

[dominicc (has gone to gerrit), 2016-12-21 07:54:11]

PTAL

[commit-bot: I haz the power, 2016-12-21 09:32:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 09:32:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kochi, 2016-12-21 09:34:43]

LGTM

At first I didn't understand how DOMTokenList.cpp changes
affect Element::setAttribute(), but realized that
ClassList class extends DOMTokenList and overrides
setValue() to call Element::setAttribute() :)

So DOMTokenList::setAttribute() change is just for
avoiding performance regression for the change in
DOMTokenList::remove().

[kochi, 2016-12-21 09:42:58]

One of the two failures in
imported/wpt/dom/nodes/MutationObserver-attributes.html
seems fixed by this.

[dominicc (has gone to gerrit), 2016-12-22 01:42:24]

Rebaseline MutationObserver test. (Thanks!)

[dominicc (has gone to gerrit), 2016-12-22 01:42:25]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2016-12-22 01:42:26]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2593973002/#ps20001
(title: "Rebaseline MutationObserver test. (Thanks!)")

[commit-bot: I haz the power, 2016-12-22 01:42:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-22 03:59:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482370945815200,
"parent_rev": "3f7ea6540b3c405702c25b0f8442519c261f84c5", "commit_rev":
"892d19bf15d7e6f209e2ad95c78077d378c7aae4"}

[commit-bot: I haz the power, 2016-12-22 03:59:44]

Description was changed from

==========
Queue custom element attribute reactions for no-op sets, removes

The DOM spec says to set attributes, even if their values don't
change, and it is the attribute *setting* which triggers custom
elements attributeChangedCallbacks. In hindsight that callback could
be better named.

BUG=676247
==========

to

==========
Queue custom element attribute reactions for no-op sets, removes

The DOM spec says to set attributes, even if their values don't
change, and it is the attribute *setting* which triggers custom
elements attributeChangedCallbacks. In hindsight that callback could
be better named.

BUG=676247

Review-Url: https://codereview.chromium.org/2593973002
==========

[commit-bot: I haz the power, 2016-12-22 03:59:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-22 04:01:14]

Description was changed from

==========
Queue custom element attribute reactions for no-op sets, removes

The DOM spec says to set attributes, even if their values don't
change, and it is the attribute *setting* which triggers custom
elements attributeChangedCallbacks. In hindsight that callback could
be better named.

BUG=676247

Review-Url: https://codereview.chromium.org/2593973002
==========

to

==========
Queue custom element attribute reactions for no-op sets, removes

The DOM spec says to set attributes, even if their values don't
change, and it is the attribute *setting* which triggers custom
elements attributeChangedCallbacks. In hindsight that callback could
be better named.

BUG=676247

Committed: https://crrev.com/1ba3273c3c421d97ee7ca9570782874cef380275
Cr-Commit-Position: refs/heads/master@{#440334}
==========

[commit-bot: I haz the power, 2016-12-22 04:01:15]

Patchset 2 (id:??) landed as
https://crrev.com/1ba3273c3c421d97ee7ca9570782874cef380275
Cr-Commit-Position: refs/heads/master@{#440334}