ash: Fix status bubble is vertically offset after switching desktops

Fix status bubble is vertically offset after switching desktops

Changes:
Do not AdjustBoundsToEnsureMinimumWindowVisibility if window is transient

BUG=624806
TEST=emulator test, also add test coverage

Review-Url: https://codereview.chromium.org/2593953002
Cr-Commit-Position: refs/heads/master@{#441822}
Committed: https://chromium.googlesource.com/chromium/src/+/7c2d8440c9c23b793c29aeef48dc18d4059d7681

[Qiang(Joe) Xu, 2016-12-21 06:52:48]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 06:53:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2016-12-21 06:57:22]

Description was changed from

==========
Fix status bubble is vertically offset after switching desktops

BUG=624806
TEST=emulator test
==========

to

==========
Fix status bubble is vertically offset after switching desktops

Changes:
Do not AdjustBoundsToEnsureMinimumWindowVisibility if window is transient

BUG=624806
TEST=emulator test
==========

[Qiang(Joe) Xu, 2016-12-21 06:57:22]

warx@chromium.org changed reviewers:
+ sky@chromium.org

[Qiang(Joe) Xu, 2016-12-21 06:59:23]

Hi sky@, ptal, thanks!

[commit-bot: I haz the power, 2016-12-21 07:56:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 07:56:08]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-03 22:37:23]

https://codereview.chromium.org/2593953002/diff/1/ash/common/wm/default_state.cc
File ash/common/wm/default_state.cc (right):

https://codereview.chromium.org/2593953002/diff/1/ash/common/wm/default_state...
ash/common/wm/default_state.cc:41: bool IsTransient(const WmWindow* window) {
Can you inline this? I don't think it's save much.

[sky, 2017-01-03 22:37:43]

Also, how about test coverage?

[Qiang(Joe) Xu, 2017-01-05 06:31:58]

Description was changed from

==========
Fix status bubble is vertically offset after switching desktops

Changes:
Do not AdjustBoundsToEnsureMinimumWindowVisibility if window is transient

BUG=624806
TEST=emulator test
==========

to

==========
Fix status bubble is vertically offset after switching desktops

Changes:
Do not AdjustBoundsToEnsureMinimumWindowVisibility if window is transient

BUG=624806
TEST=emulator test, also add test coverage
==========

[Qiang(Joe) Xu, 2017-01-05 06:32:47]

Hi sky@, test coverage is added, please take a look, thanks!

https://codereview.chromium.org/2593953002/diff/1/ash/common/wm/default_state.cc
File ash/common/wm/default_state.cc (right):

https://codereview.chromium.org/2593953002/diff/1/ash/common/wm/default_state...
ash/common/wm/default_state.cc:41: bool IsTransient(const WmWindow* window) {
On 2017/01/03 22:37:23, sky wrote:
> Can you inline this? I don't think it's save much.

Done.

[Qiang(Joe) Xu, 2017-01-05 15:34:28]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 15:34:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 16:05:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 16:05:44]

Dry run: This issue passed the CQ dry run.

[sky, 2017-01-05 17:20:37]

LGTM - thanks for including a test

[Qiang(Joe) Xu, 2017-01-06 00:15:29]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-01-06 00:16:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:13:42]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483661729324570,
"parent_rev": "f4c89ab6c9e2d821172cd1cded6163aefa894c11", "commit_rev":
"7c2d8440c9c23b793c29aeef48dc18d4059d7681"}

[commit-bot: I haz the power, 2017-01-06 02:14:12]

Description was changed from

==========
Fix status bubble is vertically offset after switching desktops

Changes:
Do not AdjustBoundsToEnsureMinimumWindowVisibility if window is transient

BUG=624806
TEST=emulator test, also add test coverage
==========

to

==========
Fix status bubble is vertically offset after switching desktops

Changes:
Do not AdjustBoundsToEnsureMinimumWindowVisibility if window is transient

BUG=624806
TEST=emulator test, also add test coverage

Review-Url: https://codereview.chromium.org/2593953002
Cr-Commit-Position: refs/heads/master@{#441822}
Committed:
https://chromium.googlesource.com/chromium/src/+/7c2d8440c9c23b793c29aeef48dc...
==========

[commit-bot: I haz the power, 2017-01-06 02:14:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7c2d8440c9c23b793c29aeef48dc...