Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2593933003: Revert of Get rid of verify-with-timeout in spellcheck_test (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Get rid of verify-with-timeout in spellcheck_test (patchset #3 id:40001 of https://codereview.chromium.org/2590823006/ ) Reason for revert: Introducing flakiness to WebKit Linux Trusty Leak: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=editing%2Fspelling Original issue's description: > Get rid of verify-with-timeout in spellcheck_test > > For spell-checking layout tests, marker verification used to be setting > a timeout and wait. This patch utilizes > testRunner.setSpellCheckResolvedCallback, and if no new marker is expected > (in which case there might be no request), testRunner.runIdleTasks, to > reduce futile waiting. > > We expect to see spell-checking tests run faster after this patch. > > BUG=674819 > > Committed: https://crrev.com/d54cef0fcd7ce30563f7abcd07a80b0958d7e504 > Cr-Commit-Position: refs/heads/master@{#440058} TBR=tkent@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=674819 Committed: https://crrev.com/e2c58f5f2da94a216531ab511f1f77da8037b428 Cr-Commit-Position: refs/heads/master@{#440068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -91 lines) Patch
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js View 4 chunks +62 lines, -91 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Xiaocheng
Created Revert of Get rid of verify-with-timeout in spellcheck_test
4 years ago (2016-12-21 10:22:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593933003/1
4 years ago (2016-12-21 10:23:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 10:24:11 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e2c58f5f2da94a216531ab511f1f77da8037b428 Cr-Commit-Position: refs/heads/master@{#440068}
4 years ago (2016-12-21 10:27:13 UTC) #8
tkent
4 years ago (2016-12-21 14:43:57 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698