Chromium Code Reviews
DescriptionRevert of Get rid of verify-with-timeout in spellcheck_test (patchset #3 id:40001 of https://codereview.chromium.org/2590823006/ )
Reason for revert:
Introducing flakiness to WebKit Linux Trusty Leak:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=editing%2Fspelling
Original issue's description:
> Get rid of verify-with-timeout in spellcheck_test
>
> For spell-checking layout tests, marker verification used to be setting
> a timeout and wait. This patch utilizes
> testRunner.setSpellCheckResolvedCallback, and if no new marker is expected
> (in which case there might be no request), testRunner.runIdleTasks, to
> reduce futile waiting.
>
> We expect to see spell-checking tests run faster after this patch.
>
> BUG=674819
>
> Committed: https://crrev.com/d54cef0fcd7ce30563f7abcd07a80b0958d7e504
> Cr-Commit-Position: refs/heads/master@{#440058}
TBR=tkent@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=674819
Committed: https://crrev.com/e2c58f5f2da94a216531ab511f1f77da8037b428
Cr-Commit-Position: refs/heads/master@{#440068}
Patch Set 1 #
Messages
Total messages: 9 (4 generated)
|
|||||||||||||||||||