Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2593933002: Revert of Enable no-compile tests on non-windows and non-ios clang (Closed)

Created:
4 years ago by wychen
Modified:
4 years ago
Reviewers:
jbudorick, Nico, dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable no-compile tests on non-windows and non-ios clang (patchset #3 id:40001 of https://codereview.chromium.org/2504383002/ ) Reason for revert: Break Mac compilation. https://build.chromium.org/p/chromium/builders/Mac/builds/22001/steps/compile/logs/stdio Original issue's description: > Enable no-compile tests on non-windows and non-ios clang > > BUG=105388 > > Committed: https://crrev.com/2c255b993eed2520629078b6f89992edd4303563 > Cr-Commit-Position: refs/heads/master@{#440024} TBR=dcheng@chromium.org,jbudorick@chromium.org,thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=105388 Committed: https://crrev.com/256ea14b868202a4f2a8ddd27cd70794f0515598 Cr-Commit-Position: refs/heads/master@{#440034}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/nocompile.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
wychen
Created Revert of Enable no-compile tests on non-windows and non-ios clang
4 years ago (2016-12-21 05:59:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593933002/1
4 years ago (2016-12-21 05:59:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-21 06:03:11 UTC) #6
commit-bot: I haz the power
4 years ago (2016-12-21 06:06:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/256ea14b868202a4f2a8ddd27cd70794f0515598
Cr-Commit-Position: refs/heads/master@{#440034}

Powered by Google App Engine
This is Rietveld 408576698