Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2593893002: [Devtools] Fixes regression caused by experiment for network popover (Closed)

Created:
3 years, 12 months ago by allada
Modified:
3 years, 12 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixes regression caused by experiment for network popover This patch fixes a regression caused by network panel not properly showing popover when colored bars are on in network panel and hover over a request in waterfall. R=dgozman BUG=664704 Committed: https://crrev.com/c6cbb8dfd02ecd7f4f7f4c71f089eb9403c31e76 Cr-Commit-Position: refs/heads/master@{#439994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
allada
PTL
3 years, 12 months ago (2016-12-21 00:51:18 UTC) #2
dgozman
lgtm
3 years, 12 months ago (2016-12-21 00:53:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593893002/1
3 years, 12 months ago (2016-12-21 03:09:02 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 12 months ago (2016-12-21 03:14:07 UTC) #13
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 03:16:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6cbb8dfd02ecd7f4f7f4c71f089eb9403c31e76
Cr-Commit-Position: refs/heads/master@{#439994}

Powered by Google App Engine
This is Rietveld 408576698