Fix use-after-free issue in VideoDecoderResourceTest.

Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman@chromium.org

Committed: https://crrev.com/e9416e5d3947a57e2217a8aa63535f9cf9c4ca15
Cr-Commit-Position: refs/heads/master@{#439961}

[krasin1, 2016-12-21 00:50:42]

krasin@chromium.org changed reviewers:
+ piman@chromium.org

[krasin1, 2016-12-21 00:50:43]

Hi Antoine,

you seem to be the sole owner of ppapi/proxy. Feel free to review when you're
back.

Since it's a simple change that fixes a memory corruption bug, I will submit it
as TBR. Feel free to revert if you see any issues with the change.

[krasin1, 2016-12-21 00:50:54]

Description was changed from

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
==========

to

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman
==========

[krasin1, 2016-12-21 00:50:57]

The CQ bit was checked by krasin@chromium.org

[krasin1, 2016-12-21 00:51:12]

Description was changed from

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman
==========

to

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman@chromium.org
==========

[commit-bot: I haz the power, 2016-12-21 00:51:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:10:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482281457789840, "parent_rev":
"e09988d81a5ae9719a73b28a49f8f063806b5f91", "commit_rev":
"7a29bdee72aa7574163ee3da90536edba55646eb"}

[commit-bot: I haz the power, 2016-12-21 01:12:10]

Description was changed from

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman@chromium.org
==========

to

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2593873002
==========

[commit-bot: I haz the power, 2016-12-21 01:12:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-21 01:16:02]

Description was changed from

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2593873002
==========

to

==========
Fix use-after-free issue in VideoDecoderResourceTest.

Local variables responsible for shared memory go out of scope
right after their initialization and then accessed by the saved
references to the stack space which is already potentially reused
for other local variables.

The bug was found by AddressSanitizer with use-after-free check
enabled. It's currently being rolled out into Chrome, and this CL
is a part of a larger cleanup of existing failures.

BUG=649897
TBR=piman@chromium.org

Committed: https://crrev.com/e9416e5d3947a57e2217a8aa63535f9cf9c4ca15
Cr-Commit-Position: refs/heads/master@{#439961}
==========

[commit-bot: I haz the power, 2016-12-21 01:16:02]

Patchset 1 (id:??) landed as
https://crrev.com/e9416e5d3947a57e2217a8aa63535f9cf9c4ca15
Cr-Commit-Position: refs/heads/master@{#439961}

[piman, 2017-03-06 22:01:58]

belated LGTM and thanks!