Fix evil retry loop on poll errors.

Fix evil retry loop on poll errors.

There was no sleep when retrying poll errors (due to a regression).

BUG=675483
R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2593863002
Committed: https://github.com/luci/luci-py/commit/f25ef8dfd624f0a4c42af66d9bab9d3c8a0523ae

[Vadim Sh., 2016-12-21 00:27:17]

PTAL

See the bug.

https://codereview.chromium.org/2593863002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/bot_main.py (left):

https://codereview.chromium.org/2593863002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/bot_main.py:573: if cmd == '':
on errors, cmd was None here. None != '' => no sleep :(

https://codereview.chromium.org/2593863002/diff/1/appengine/swarming/swarming...
File appengine/swarming/swarming_bot/bot_code/bot_main.py (right):

https://codereview.chromium.org/2593863002/diff/1/appengine/swarming/swarming...
appengine/swarming/swarming_bot/bot_code/bot_main.py:553:
logging.exception('poll_server failed in a completely unexpected way')
:) 
in theory, this should never happen.

[M-A Ruel, 2016-12-21 00:37:27]

thanks, lgtm

[Vadim Sh., 2016-12-21 00:41:18]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2016-12-21 00:41:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 00:44:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1482280878295360, "parent_rev":
"026a92193f6793d60501bc27fe59e85d92f888db", "commit_rev":
"f25ef8dfd624f0a4c42af66d9bab9d3c8a0523ae"}

[commit-bot: I haz the power, 2016-12-21 00:45:02]

Description was changed from

==========
Fix evil retry loop on poll errors.

There was no sleep when retrying poll errors (due to a regression).

BUG=675483
R=maruel@chromium.org
==========

to

==========
Fix evil retry loop on poll errors.

There was no sleep when retrying poll errors (due to a regression).

BUG=675483
R=maruel@chromium.org

Review-Url: https://codereview.chromium.org/2593863002
Committed:
https://github.com/luci/luci-py/commit/f25ef8dfd624f0a4c42af66d9bab9d3c8a0523ae
==========

[commit-bot: I haz the power, 2016-12-21 00:45:02]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/f25ef8dfd624f0a4c42af66d9bab9d3c8a0523ae