Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 2593823002: [cctest] print name instead of context index for CallJSRuntime (Closed)

Created:
4 years ago by caitp
Modified:
4 years ago
Reviewers:
rmcilroy, neis, adamk, mythria
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cctest] print name instead of context index for CallJSRuntime Change bytecode-expectations-printer.cc in the cctest application so that intrinsic function names are printed rather than their native context index. This minimizes the amount of unnecessary changes to the bytecode expectations that need to happen whenever the context fields are changed. BUG=v8:5769 R=neis@chromium.org, rmcilroy@chromium.org, adamk@chromium.org Review-Url: https://codereview.chromium.org/2593823002 Cr-Commit-Position: refs/heads/master@{#41900} Committed: https://chromium.googlesource.com/v8/v8/+/3d6a477bd00603fd262ce5e73569a45978311444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M test/cctest/interpreter/bytecode-expectations-printer.cc View 2 chunks +23 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/CallRuntime.golden View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/interpreter/bytecode_expectations/SuperCallAndSpread.golden View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
caitp
Hi, PTAL There are some alternative approaches that might be cleaner, but this seemed like ...
4 years ago (2016-12-20 21:24:53 UTC) #7
adamk
+mythria while rmcilroy's OOO
4 years ago (2016-12-20 21:29:57 UTC) #9
mythria
Nice, lgtm.
4 years ago (2016-12-21 09:34:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593823002/1
4 years ago (2016-12-21 16:38:34 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-21 16:41:15 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/3d6a477bd00603fd262ce5e73569a459783...

Powered by Google App Engine
This is Rietveld 408576698