simplify scrollcanvas to always use shared code

simplify scrollcanvas to always use shared code

note: scrollcanvas is only called by pepper

BUG=675977
Committed: https://crrev.com/7a0a39813c19a9ea94360879ff7f1bd46adcf78c
Cr-Commit-Position: refs/heads/master@{#440134}

[reed1, 2016-12-21 15:52:37]

Description was changed from

==========
simplify scrollcanvas to always use shared code

BUG=675977
==========

to

==========
simplify scrollcanvas to always use shared code

note: scrollcanvas is only called by pepper

BUG=675977
==========

[reed1, 2016-12-21 15:52:42]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 15:53:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[reed1, 2016-12-21 15:53:36]

reed@google.com changed reviewers:
+ danakj@chromium.org, fmalita@chromium.org, msw@chromium.org

[danakj, 2016-12-21 15:56:11]

https://codereview.chromium.org/2593803004/diff/1/ui/gfx/blit.cc
File ui/gfx/blit.cc (right):

https://codereview.chromium.org/2593803004/diff/1/ui/gfx/blit.cc#newcode77
ui/gfx/blit.cc:77: DCHECK(success);
Either DCHECK or do the if (!) return, but not both. Can this happen and we need
to handle it or should it never happen?

[msw, 2016-12-21 15:56:59]

rubber stamp lgtm (I don't know this code too well, but this seems ok)

[reed1, 2016-12-21 15:58:30]

https://codereview.chromium.org/2593803004/diff/1/ui/gfx/blit.cc
File ui/gfx/blit.cc (right):

https://codereview.chromium.org/2593803004/diff/1/ui/gfx/blit.cc#newcode77
ui/gfx/blit.cc:77: DCHECK(success);
On 2016/12/21 15:56:11, danakj_OOO_and_slow wrote:
> Either DCHECK or do the if (!) return, but not both. Can this happen and we
need
> to handle it or should it never happen?

We never checked before, so I'd guess it never happens.

I was following the pattern of DCHECK + return from HasClipOrTransform() just
above. Happy to just do one or the other.

[danakj, 2016-12-21 16:03:29]

https://codereview.chromium.org/2593803004/diff/1/ui/gfx/blit.cc
File ui/gfx/blit.cc (right):

https://codereview.chromium.org/2593803004/diff/1/ui/gfx/blit.cc#newcode77
ui/gfx/blit.cc:77: DCHECK(success);
On 2016/12/21 15:58:30, reed1 wrote:
> On 2016/12/21 15:56:11, danakj_OOO_and_slow wrote:
> > Either DCHECK or do the if (!) return, but not both. Can this happen and we
> need
> > to handle it or should it never happen?
> 
> We never checked before, so I'd guess it never happens.
> 
> I was following the pattern of DCHECK + return from HasClipOrTransform() just
> above. Happy to just do one or the other.

Ya that shouldn't be done, our style guide is explicit about that. It looks to
me like DCHECK would be right here looking at the code, but you'd know best.

[reed1, 2016-12-21 16:08:50]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 16:09:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-12-21 16:09:34]

LGTM

[reed1, 2016-12-21 16:16:30]

The CQ bit was unchecked by reed@google.com

[reed1, 2016-12-21 16:16:34]

The CQ bit was checked by reed@google.com

[reed1, 2016-12-21 16:16:35]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2593803004/#ps20001
(title: "just use DCHECK")

[commit-bot: I haz the power, 2016-12-21 16:16:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 17:13:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482336994643320,
"parent_rev": "95c812ef9ca47230927a85b7110d68d24619fbcb", "commit_rev":
"f1ebc9e32c3f50fa9ab452977a4a493787e35c6d"}

[commit-bot: I haz the power, 2016-12-21 17:14:26]

Description was changed from

==========
simplify scrollcanvas to always use shared code

note: scrollcanvas is only called by pepper

BUG=675977
==========

to

==========
simplify scrollcanvas to always use shared code

note: scrollcanvas is only called by pepper

BUG=675977

Review-Url: https://codereview.chromium.org/2593803004
==========

[commit-bot: I haz the power, 2016-12-21 17:14:27]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-21 17:17:16]

Description was changed from

==========
simplify scrollcanvas to always use shared code

note: scrollcanvas is only called by pepper

BUG=675977

Review-Url: https://codereview.chromium.org/2593803004
==========

to

==========
simplify scrollcanvas to always use shared code

note: scrollcanvas is only called by pepper

BUG=675977

Committed: https://crrev.com/7a0a39813c19a9ea94360879ff7f1bd46adcf78c
Cr-Commit-Position: refs/heads/master@{#440134}
==========

[commit-bot: I haz the power, 2016-12-21 17:17:16]

Patchset 2 (id:??) landed as
https://crrev.com/7a0a39813c19a9ea94360879ff7f1bd46adcf78c
Cr-Commit-Position: refs/heads/master@{#440134}