Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2593803003: s390: exploit high-word facility for Smi Ops (Closed)

Created:
4 years ago by john.yan
Modified:
4 years ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: exploit high-word facility for Smi Ops R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2593803003 Cr-Commit-Position: refs/heads/master@{#41881} Committed: https://chromium.googlesource.com/v8/v8/+/d0e71c57e9670faa84fc3fd6273ae28c1bf659f9

Patch Set 1 #

Patch Set 2 : check distinct opts #

Patch Set 3 : add cih and clih #

Patch Set 4 : sim and disassem #

Patch Set 5 : fix native failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -17 lines) Patch
M src/s390/code-stubs-s390.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/s390/disasm-s390.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 2 4 chunks +26 lines, -8 lines 0 comments Download
M src/s390/simulator-s390.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/simulator-s390.cc View 1 2 3 3 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
john.yan
ptal
4 years ago (2016-12-20 21:33:06 UTC) #1
JoranSiu
On 2016/12/20 21:33:06, john.yan wrote: > ptal lgtm
4 years ago (2016-12-20 22:12:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593803003/60001
4 years ago (2016-12-20 22:13:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2593803003/80001
4 years ago (2016-12-21 00:59:05 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-21 01:24:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/d0e71c57e9670faa84fc3fd6273ae28c1bf...

Powered by Google App Engine
This is Rietveld 408576698